Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1636)

Unified Diff: mojo/public/python/mojo_system.pyx

Issue 1364463006: Make Python not support "all or none" for two-phase data pipe read/write. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/public/dart/tools/fetch_dart_packages.py ('k') | mojo/python/tests/system_unittest.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/public/python/mojo_system.pyx
diff --git a/mojo/public/python/mojo_system.pyx b/mojo/public/python/mojo_system.pyx
index e07b0e61bfa3528cf8f39167a64bc7d07d531f43..31ef2a4004773782b1ea55e80f509e77f82771b7 100644
--- a/mojo/public/python/mojo_system.pyx
+++ b/mojo/public/python/mojo_system.pyx
@@ -491,8 +491,7 @@ cdef class Handle(object):
return (res, None)
def BeginWriteData(self,
- min_size=None,
- flags=WRITE_DATA_FLAG_NONE):
+ flags=WRITE_DATA_FLAG_NONE):
"""
Begins a two-phase write to the data pipe producer.
@@ -508,9 +507,6 @@ cdef class Handle(object):
"""
cdef void* out_buffer
cdef uint32_t out_size = 0
- if min_size:
- flags |= c_core.MOJO_WRITE_DATA_FLAG_ALL_OR_NONE
- out_size = min_size
cdef c_core.MojoResult res = c_core.MojoBeginWriteData(self._mojo_handle,
&out_buffer,
&out_size,
@@ -565,7 +561,7 @@ cdef class Handle(object):
flags|c_core.MOJO_READ_DATA_FLAG_QUERY)
return (res, num_bytes)
- def BeginReadData(self, min_size=None, flags=READ_DATA_FLAG_NONE):
+ def BeginReadData(self, flags=READ_DATA_FLAG_NONE):
"""
Begins a two-phase read to the data pipe consumer.
@@ -581,9 +577,6 @@ cdef class Handle(object):
"""
cdef const void* out_buffer
cdef uint32_t out_size = 0
- if min_size:
- flags |= c_core.MOJO_READ_DATA_FLAG_ALL_OR_NONE
- out_size = min_size
cdef c_core.MojoResult res = c_core.MojoBeginReadData(self._mojo_handle,
&out_buffer,
&out_size,
« no previous file with comments | « mojo/public/dart/tools/fetch_dart_packages.py ('k') | mojo/python/tests/system_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698