Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Issue 1364463006: Make Python not support "all or none" for two-phase data pipe read/write. (Closed)

Created:
5 years, 2 months ago by viettrungluu
Modified:
5 years, 2 months ago
Reviewers:
vardhan
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Make Python not support "all or none" for two-phase data pipe read/write. Note: The data pipe tests are somewhat dependent on implementation at a lower level. E.g., there's no guarantee that after a write, all the data written becomes available "atomically". There's also no guarantee on the size of the read/write buffers for two-phase reads/writes -- even if a two-phase write of a given size was done, there's no guarantee that a corresponding two-phase read will have a buffer of the same size available. However, I've left the tests alone for now. BUG=#366 R=vardhan@google.com Committed: https://chromium.googlesource.com/external/mojo/+/7e232ee45eefa05a19e137850377e6151a260e88

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -15 lines) Patch
M mojo/public/dart/tools/fetch_dart_packages.py View 1 chunk +6 lines, -5 lines 0 comments Download
M mojo/public/python/mojo_system.pyx View 4 chunks +2 lines, -9 lines 0 comments Download
M mojo/python/tests/system_unittest.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
viettrungluu
5 years, 2 months ago (2015-09-25 18:29:09 UTC) #1
vardhan
lgtm
5 years, 2 months ago (2015-09-25 21:41:44 UTC) #2
vardhan
lgtm
5 years, 2 months ago (2015-09-25 21:41:45 UTC) #3
viettrungluu
5 years, 2 months ago (2015-09-25 22:04:02 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
7e232ee45eefa05a19e137850377e6151a260e88 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698