Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1997)

Issue 1364463005: Avoid copies in SkMasks constructor (Closed)

Created:
5 years, 2 months ago by scroggo
Modified:
5 years, 2 months ago
Reviewers:
msarett
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@codecSDmerge
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid copies in SkMasks constructor Also mark const methods as const. Committed: https://skia.googlesource.com/skia/+/8b17dcb72cfbfb1e9451a311f927291a48a84d79

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -14 lines) Patch
M src/codec/SkMasks.h View 3 chunks +8 lines, -8 lines 0 comments Download
M src/codec/SkMasks.cpp View 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
scroggo
5 years, 2 months ago (2015-09-25 18:09:05 UTC) #2
msarett
lgtm
5 years, 2 months ago (2015-09-28 00:49:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364463005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364463005/1
5 years, 2 months ago (2015-09-28 13:08:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2885)
5 years, 2 months ago (2015-09-28 13:09:00 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364463005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364463005/20001
5 years, 2 months ago (2015-09-30 19:15:30 UTC) #10
commit-bot: I haz the power
5 years, 2 months ago (2015-09-30 19:27:04 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/8b17dcb72cfbfb1e9451a311f927291a48a84d79

Powered by Google App Engine
This is Rietveld 408576698