gm/surface.cpp - Issue 1364443002: remove unused (by the outside) SkImage::newSurface, and simplify newImage -> newSubset

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gm/surface.cpp

Issue 1364443002: remove unused (by the outside) SkImage::newSurface, and simplify newImage -> newSubset (Closed) Base URL: https://skia.googlesource.com/skia.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: gm/surface.cpp

diff --git a/gm/surface.cpp b/gm/surface.cpp

index bf7f931f468240f6dca186a996bb8ab2504c5947..8c7c118cce04f735c0076bd426f4e3b02c3d9825 100644

--- a/gm/surface.cpp

+++ b/gm/surface.cpp

@@ -143,7 +143,7 @@ protected:

SkAutoTUnref<SkImage> image(surf->newImageSnapshot());

canvas->drawImage(image, 10, 10, nullptr);

- SkAutoTUnref<SkSurface> surf2(image->newSurface(info, nullptr));

+ SkAutoTUnref<SkSurface> surf2(surf->newSurface(info));

drawInto(surf2->getCanvas());

// Assert that the props were communicated transitively through the first image

« no previous file with comments | « gm/image_pict.cpp ('k') | include/core/SkImage.h » ('j') | no next file with comments »