Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Unified Diff: src/code-stubs.h

Issue 136443006: Remove special charAt and charCodeAt handling in the ICs. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Rebase Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/code-stubs.h
diff --git a/src/code-stubs.h b/src/code-stubs.h
index bc4c5cdd18648f5900043079c76df8c9afe323e3..c567e7544b83e48fb88458b93aa97b1b3d2a6801 100644
--- a/src/code-stubs.h
+++ b/src/code-stubs.h
@@ -1087,13 +1087,9 @@ class KeyedArrayCallStub: public HICStub {
return GetExtraICState() | ArgcBits::encode(argc_);
}
- // We have to start storing extra ic bits at 1, because calls use bit zero
- // for string stub state.
- STATIC_ASSERT(CallICBase::StringStubState::kShift == 0);
- STATIC_ASSERT(CallICBase::StringStubState::kSize == 1);
- class HoleyBits: public BitField<bool, 1, 1> {};
- STATIC_ASSERT(Code::kArgumentsBits <= kStubMinorKeyBits - 2);
- class ArgcBits: public BitField<int, 2, Code::kArgumentsBits> {};
+ class HoleyBits: public BitField<bool, 0, 1> {};
+ STATIC_ASSERT(Code::kArgumentsBits <= kStubMinorKeyBits - 1);
+ class ArgcBits: public BitField<int, 1, Code::kArgumentsBits> {};
virtual CodeStub::Major MajorKey() { return KeyedArrayCall; }
int bit_field_;
int argc_;
« no previous file with comments | « src/arm/stub-cache-arm.cc ('k') | src/ia32/stub-cache-ia32.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698