Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Issue 136443006: Remove special charAt and charCodeAt handling in the ICs. (Closed)

Created:
6 years, 11 months ago by Toon Verwaest
Modified:
6 years, 11 months ago
Reviewers:
mvstanton
CC:
v8-dev
Visibility:
Public.

Description

Remove special charAt and charCodeAt handling in the ICs. R=mvstanton@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18663

Patch Set 1 #

Patch Set 2 : Remove from platforms #

Patch Set 3 : Remove debug related code #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -609 lines) Patch
M src/arm/stub-cache-arm.cc View 1 2 3 1 chunk +0 lines, -132 lines 0 comments Download
M src/code-stubs.h View 1 2 3 1 chunk +3 lines, -7 lines 0 comments Download
M src/ia32/stub-cache-ia32.cc View 1 2 3 1 chunk +0 lines, -134 lines 0 comments Download
M src/ic.h View 1 2 3 1 chunk +0 lines, -12 lines 0 comments Download
M src/ic.cc View 1 2 3 1 chunk +0 lines, -49 lines 0 comments Download
M src/mips/stub-cache-mips.cc View 1 2 3 1 chunk +0 lines, -129 lines 0 comments Download
M src/objects.cc View 1 2 3 1 chunk +0 lines, -5 lines 0 comments Download
M src/stub-cache.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M src/stub-cache.cc View 1 2 3 2 chunks +4 lines, -8 lines 0 comments Download
M src/type-info.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/x64/stub-cache-x64.cc View 1 2 3 1 chunk +0 lines, -129 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Toon Verwaest
PTAL
6 years, 11 months ago (2014-01-17 10:19:30 UTC) #1
mvstanton
Very nice cleanup. lgtm.
6 years, 11 months ago (2014-01-17 11:26:24 UTC) #2
Toon Verwaest
6 years, 11 months ago (2014-01-17 11:28:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #4 manually as r18663 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698