Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 1364403003: Refine invalidation of filter clients in LayoutSVGResourceContainer (Closed)

Created:
5 years, 2 months ago by fs
Modified:
5 years, 2 months ago
Reviewers:
pdr., Stephen White
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refine invalidation of filter clients in LayoutSVGResourceContainer When an outermost <svg> had a non-filter-induced layer it would fall into the layer-oriented code-path in LayoutSVGResourceContainer::registerResource even if it didn't have a '-webkit-filter' property. Because of this, the layout object would not get invalidated (if it had a 'filter' property). Refine the conditions involved to allow both properties to trigger invalidations as needed. Also avoid the filter invalidation hack when possible and take the opportunity to make good use of a for-range loop. BUG=535800 Committed: https://crrev.com/4be2af35bd819f0958d0d12a17e96b892b8fb5a5 Cr-Commit-Position: refs/heads/master@{#350900}

Patch Set 1 #

Total comments: 5

Patch Set 2 : Drop unused misspellings. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -8 lines) Patch
A third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp View 1 chunk +15 lines, -8 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
fs
Stackin' hacks
5 years, 2 months ago (2015-09-25 12:58:14 UTC) #2
Stephen White
https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html File third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html (right): https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html#newcode9 third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html:9: <filter id='myFilter' color-interpolations-filters='sRGB'> Nit: should be color-interpolation-filters (or removed). ...
5 years, 2 months ago (2015-09-25 14:22:22 UTC) #3
Stephen White
Oh, and LGTM
5 years, 2 months ago (2015-09-25 14:22:48 UTC) #4
fs
https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html File third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html (right): https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html#newcode9 third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html:9: <filter id='myFilter' color-interpolations-filters='sRGB'> On 2015/09/25 at 14:22:22, Stephen White ...
5 years, 2 months ago (2015-09-25 14:50:40 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364403003/20001
5 years, 2 months ago (2015-09-25 20:27:52 UTC) #8
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-09-25 20:38:13 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 20:38:58 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/4be2af35bd819f0958d0d12a17e96b892b8fb5a5
Cr-Commit-Position: refs/heads/master@{#350900}

Powered by Google App Engine
This is Rietveld 408576698