Refine invalidation of filter clients in LayoutSVGResourceContainer

Refine invalidation of filter clients in LayoutSVGResourceContainer

When an outermost <svg> had a non-filter-induced layer it would fall
into the layer-oriented code-path in
LayoutSVGResourceContainer::registerResource even if it didn't have a
'-webkit-filter' property. Because of this, the layout object would not
get invalidated (if it had a 'filter' property).
Refine the conditions involved to allow both properties to trigger
invalidations as needed. Also avoid the filter invalidation hack when
possible and take the opportunity to make good use of a for-range loop.

BUG=535800
Committed: https://crrev.com/4be2af35bd819f0958d0d12a17e96b892b8fb5a5
Cr-Commit-Position: refs/heads/master@{#350900}

[fs, 2015-09-25 12:58:14]

fs@opera.com changed reviewers:
+ pdr@chromium.org, senorblanco@chromium.org

[fs, 2015-09-25 12:58:14]

Stackin' hacks

[Stephen White, 2015-09-25 14:22:22]

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html
(right):

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer-expected.html:9:
<filter id='myFilter' color-interpolations-filters='sRGB'>
Nit: should be color-interpolation-filters (or removed).

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html
(right):

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html:9:
<filter id='myFilter' color-interpolations-filters='sRGB'>
Nit: should be color-interpolation-filters (or removed).

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
(right):

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp:255: //
If this is the SVG root, we could have both 'filter' and
Should we log a bug for this case? It seems like after unprefixing, only one of
these invalidations will be necessary, no?

[Stephen White, 2015-09-25 14:22:48]

Oh, and LGTM

[fs, 2015-09-25 14:50:40]

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTe...
File third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html
(right):

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/svg/filters/filter-on-svg-root-w-layer.html:9:
<filter id='myFilter' color-interpolations-filters='sRGB'>
On 2015/09/25 at 14:22:22, Stephen White wrote:
> Nit: should be color-interpolation-filters (or removed).

I had such great plans for this presentation attribute - and then I misspelled
it... doh! Nah, who am I kidding - dropped in both files.

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp
(right):

https://codereview.chromium.org/1364403003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/svg/LayoutSVGResourceContainer.cpp:255: //
If this is the SVG root, we could have both 'filter' and
On 2015/09/25 at 14:22:22, Stephen White wrote:
> Should we log a bug for this case? It seems like after unprefixing, only one
of these invalidations will be necessary, no?

I don't think that's necessary - when the properties merge then at least part of
this code will not compile anymore (at the very least the svgStyle().hasFilter()
bit), so it ought to fall out naturally (and not run the risk of being left
behind.)

[fs, 2015-09-25 20:26:48]

The CQ bit was checked by fs@opera.com

[fs, 2015-09-25 20:26:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
senorblanco@chromium.org
Link to the patchset: https://codereview.chromium.org/1364403003/#ps20001
(title: "Drop unused misspellings.")

[commit-bot: I haz the power, 2015-09-25 20:27:52]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364403003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364403003/20001

[commit-bot: I haz the power, 2015-09-25 20:38:13]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-25 20:38:58]

Patchset 2 (id:??) landed as
https://crrev.com/4be2af35bd819f0958d0d12a17e96b892b8fb5a5
Cr-Commit-Position: refs/heads/master@{#350900}