Full code shouldn't embed the type feedback vector.

Full code shouldn't embed the type feedback vector.

Make sure to always reference it indirectly. This allows us to make the vector
native-context dependent should we wish.

R=ishell@chromium.org
BUG=

Committed: https://crrev.com/c90c60ba2689fb524a1526503c9c87f534cf58fb
Cr-Commit-Position: refs/heads/master@{#30940}

[mvstanton, 2015-09-25 11:11:34]

Hi Igor,
Here is the CL we discussed. Platform ports to follow. Now, full code doesn't
embed the vector anywhere, nor does it need the vector to have been created
beforehand (though it still is right now).

[mvstanton, 2015-09-25 12:54:13]

mvstanton@chromium.org changed reviewers:
+ jkummerow@chromium.org

[mvstanton, 2015-09-25 12:54:13]

Hi Igor, here are the ports.
Jakob, could you look at the full-codegen change?
Thanks!
--Michael

[Jakob Kummerow, 2015-09-25 13:08:05]

src/full-codegen/* LGTM.

https://codereview.chromium.org/1364373003/diff/20001/src/type-feedback-vecto...
File src/type-feedback-vector.cc (right):

https://codereview.chromium.org/1364373003/diff/20001/src/type-feedback-vecto...
src/type-feedback-vector.cc:136: int TypeFeedbackVector::GetIndexFromSpec(const
Spec* spec,
As discussed, I'd advocate to combine this with the existing
TypeFeedbackVector::GetIndex implementation; but since you said they're both
scheduled to be replaced soon, I don't mind the temporary duplication of logic.

[Igor Sheludko, 2015-09-25 13:16:02]

lgtm

[mvstanton, 2015-09-25 13:19:19]

The CQ bit was checked by mvstanton@chromium.org

[commit-bot: I haz the power, 2015-09-25 13:19:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364373003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364373003/20001

[commit-bot: I haz the power, 2015-09-25 13:56:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-09-25 13:56:51]

Patchset 2 (id:??) landed as
https://crrev.com/c90c60ba2689fb524a1526503c9c87f534cf58fb
Cr-Commit-Position: refs/heads/master@{#30940}

[Benedikt Meurer, 2015-09-25 16:06:10]

bmeurer@chromium.org changed reviewers:
+ bmeurer@chromium.org

[Benedikt Meurer, 2015-09-25 16:06:10]

Awesome!