[analyzer] copy generic type args when inferring a new function type for an ExecutableElement

[analyzer] copy generic type args when inferring a new function type for an ExecutableElement

This matches what resolver.dart visitMethodDeclaration does when it creats the FunctionTypeImpl for the method. So we want to preserve these generic type args when we're building the new inferred function type, otherwise we'll fail to substitute them later on.

Context: https://github.com/dart-lang/dev_compiler/issues/342#issuecomment-142748853

R=brianwilkerson@google.com

Committed: https://github.com/dart-lang/sdk/commit/59eb287389641b662b9fbb8d3ee541088aaa98d1

[Jennifer Messerly, 2015-09-24 22:35:30]

jmesserly@google.com changed reviewers:
+ brianwilkerson@google.com, leafp@google.com

[Jennifer Messerly, 2015-09-24 22:35:56]

https://codereview.chromium.org/1364353003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong_mode.dart (right):

https://codereview.chromium.org/1364353003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong_mode.dart:32: ..typeArguments =
functionType.typeArguments;
not sure if y'all use cascades, let me know if there's a better way to format
this.

https://codereview.chromium.org/1364353003/diff/20001/pkg/analyzer/test/src/t...
File pkg/analyzer/test/src/task/strong_mode_test.dart (right):

https://codereview.chromium.org/1364353003/diff/20001/pkg/analyzer/test/src/t...
pkg/analyzer/test/src/task/strong_mode_test.dart:719:
expect(methodC.type.typeArguments, [typeCE],
this check was failing without the fix.

[Brian Wilkerson, 2015-09-24 22:49:27]

LGTM

https://codereview.chromium.org/1364353003/diff/20001/pkg/analyzer/lib/src/ta...
File pkg/analyzer/lib/src/task/strong_mode.dart (right):

https://codereview.chromium.org/1364353003/diff/20001/pkg/analyzer/lib/src/ta...
pkg/analyzer/lib/src/task/strong_mode.dart:32: ..typeArguments =
functionType.typeArguments;
I haven't gotten in the habit of using them much, but don't have a problem with
them being used. As for formatting, we always run the formatter over everything
so that formatting is never a question.

[Jennifer Messerly, 2015-09-25 17:03:14]

Committed patchset #2 (id:20001) manually as
59eb287389641b662b9fbb8d3ee541088aaa98d1 (presubmit successful).