Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(782)

Unified Diff: ppapi/tests/test_file_ref.cc

Issue 13643004: Enable PPB_DirectoryReader_Dev under NaCl (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ppapi/tests/test_file_ref.cc
diff --git a/ppapi/tests/test_file_ref.cc b/ppapi/tests/test_file_ref.cc
index 741b6b28a078049e195cc11a70af5e48c94d3c5e..2dfea855d1d8b0281b8e884bd9bc231b66862d8e 100644
--- a/ppapi/tests/test_file_ref.cc
+++ b/ppapi/tests/test_file_ref.cc
@@ -32,9 +32,7 @@ const char* kTempFileName = "temporary";
const char* kParentPath = "/foo/bar";
const char* kPersFilePath = "/foo/bar/persistent";
const char* kTempFilePath = "/foo/bar/temporary";
-#ifndef PPAPI_OS_NACL // Only used for a test that NaCl can't run yet.
const char* kTerribleName = "!@#$%^&*()-_=+{}[] ;:'\"|`~\t\n\r\b?";
-#endif
std::string ReportMismatch(const std::string& method_name,
const std::string& returned_result,
@@ -81,9 +79,7 @@ void TestFileRef::RunTests(const std::string& filter) {
RUN_TEST_FORCEASYNC_AND_NOT(DeleteFileAndDirectory, filter);
RUN_TEST_FORCEASYNC_AND_NOT(RenameFileAndDirectory, filter);
RUN_CALLBACK_TEST(TestFileRef, Query, filter);
-#ifndef PPAPI_OS_NACL // NaCl can't run this test yet.
RUN_TEST_FORCEASYNC_AND_NOT(FileNameEscaping, filter);
-#endif
}
std::string TestFileRef::TestCreate() {
@@ -745,7 +741,6 @@ std::string TestFileRef::TestQuery() {
PASS();
}
-#ifndef PPAPI_OS_NACL
std::string TestFileRef::TestFileNameEscaping() {
TestCompletionCallback callback(instance_->pp_instance(), force_async_);
pp::FileSystem file_system(instance_, PP_FILESYSTEMTYPE_LOCALTEMPORARY);
@@ -803,4 +798,3 @@ std::string TestFileRef::TestFileNameEscaping() {
PASS();
}
-#endif

Powered by Google App Engine
This is Rietveld 408576698