Issue 13643004: Enable PPB_DirectoryReader_Dev under NaCl

Issue 13643004: Enable PPB_DirectoryReader_Dev under NaCl (Closed)

Created:
7 years, 8 months ago by nhiroki

Modified:
7 years, 8 months ago

Reviewers:
dmichael (off chromium), yzshen1

CC:
chromium-reviews, Yusuke Sato

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Enable PPB_DirectoryReader_Dev under NaCl TEST=browser_tests --gtest_filter=\*DirectoryReader\* Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192517

Patch Set 2 : review fix and add tests #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -22 lines)			Patch
M	chrome/test/ppapi/ppapi_browsertest.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	ppapi/ppapi_shared.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	ppapi/proxy/resource_creation_proxy.cc	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	ppapi/tests/test_file_ref.cc	View		4 chunks	+0 lines, -6 lines	0 comments	Download
M	ppapi/thunk/interfaces_ppb_public_dev.h	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	ppapi/thunk/resource_creation_api.h	View		2 chunks	+2 lines, -3 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

nhiroki

Hi, could you review this? This patch moves PPB_DirectoryReader_Dev to out of "#if !defined(OS_NACL)". yusukes@ ...

7 years, 8 months ago (2013-04-04 16:29:41 UTC) #1

dmichael (off chromium)

lgtm https://chromiumcodereview.appspot.com/13643004/diff/1/ppapi/thunk/interfaces_ppb_public_dev.h File ppapi/thunk/interfaces_ppb_public_dev.h (right): https://chromiumcodereview.appspot.com/13643004/diff/1/ppapi/thunk/interfaces_ppb_public_dev.h#newcode18 ppapi/thunk/interfaces_ppb_public_dev.h:18: PPB_DirectoryReader_Dev_0_6) nit: please alphabetize

7 years, 8 months ago (2013-04-04 17:03:29 UTC) #2

nhiroki

Thank you for review! Added tests for DirectoryReader under NaCl, and made sure it works ...

7 years, 8 months ago (2013-04-04 17:57:41 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/13643004/17001

7 years, 8 months ago (2013-04-04 23:23:23 UTC) #6

commit-bot: I haz the power

Retried try job too often on win_rel for step(s) sync_integration_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=131300

7 years, 8 months ago (2013-04-05 02:56:17 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nhiroki@chromium.org/13643004/17001

7 years, 8 months ago (2013-04-05 04:06:20 UTC) #8

Message was sent while issue was closed.

Change committed as 192517

Expand Messages | Collapse Messages