Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(779)

Issue 13643002: Rename LOG() to LOG_INFO() (Closed)

Created:
7 years, 8 months ago by danakj
Modified:
7 years ago
Reviewers:
jamesr, eseidel1, eseidel
CC:
blink-reviews, Mikhail, Nico
Base URL:
https://chromium.googlesource.com/chromium/blink@master
Visibility:
Public.

Description

Rename LOG() to LOG_INFO() The current macro name conflicts with a macro from the chromium base/ library. This conflict makes it very difficult to include headers from both Blink, and Chromium, since wtf/Assertions.h is included from just about anywhere in Blink. We should switch to using Chromium's logging mechanisms. But until we do this avoids conflicts between defines. Moved from: https://bugs.webkit.org/show_bug.cgi?id=101825 R=eseidel,jamesr

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+410 lines, -408 lines) Patch
M Source/WTF/wtf/Assertions.h View 1 chunk +4 lines, -4 lines 0 comments Download
M Source/WTF/wtf/RefCountedLeakCounter.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/indexeddb/IDBTracing.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/webaudio/DefaultAudioDestinationNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/webaudio/MediaElementAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/webaudio/MediaStreamAudioSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/Database.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackend.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseBackendBase.cpp View 4 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseManager.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseTask.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseThread.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/DatabaseTracker.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLStatementBackend.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransaction.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/webdatabase/SQLTransactionBackend.cpp View 6 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/Modules/websockets/WebSocket.cpp View 11 chunks +14 lines, -14 lines 0 comments Download
M Source/WebCore/Modules/websockets/WebSocketChannel.cpp View 20 chunks +27 lines, -27 lines 0 comments Download
M Source/WebCore/Modules/websockets/WebSocketDeflater.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/Modules/websockets/WebSocketHandshake.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/dom/Position.cpp View 1 chunk +7 lines, -7 lines 0 comments Download
M Source/WebCore/fileapi/FileReader.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/fileapi/FileThread.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/history/CachedFrame.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/WebCore/history/PageCache.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/FTPDirectoryDocument.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLMediaElement.cpp View 1 84 chunks +98 lines, -98 lines 0 comments Download
M Source/WebCore/html/HTMLPlugInImageElement.cpp View 6 chunks +13 lines, -13 lines 0 comments Download
M Source/WebCore/html/HTMLSourceElement.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/html/HTMLTrackElement.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/html/track/InbandTextTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/html/track/TextTrackRegion.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/loader/FrameLoader.cpp View 1 3 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/loader/HistoryController.cpp View 9 chunks +9 lines, -9 lines 0 comments Download
M Source/WebCore/loader/ProgressTracker.cpp View 1 5 chunks +7 lines, -5 lines 0 comments Download
M Source/WebCore/loader/ResourceLoadScheduler.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/loader/SubresourceLoader.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/loader/TextTrackLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/archive/cf/LegacyWebArchive.cpp View 15 chunks +25 lines, -25 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResource.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/loader/cache/CachedResourceLoader.cpp View 1 9 chunks +10 lines, -10 lines 0 comments Download
M Source/WebCore/loader/cache/MemoryCache.cpp View 1 3 chunks +3 lines, -3 lines 0 comments Download
M Source/WebCore/loader/icon/IconController.cpp View 5 chunks +5 lines, -5 lines 0 comments Download
M Source/WebCore/loader/icon/IconDatabase.cpp View 43 chunks +50 lines, -50 lines 0 comments Download
M Source/WebCore/loader/icon/IconLoader.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/loader/icon/IconRecord.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/WebCore/platform/audio/FFTFrame.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M Source/WebCore/platform/graphics/MediaPlayer.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/WebCore/platform/network/chromium/SocketStreamHandle.cpp View 7 chunks +12 lines, -12 lines 0 comments Download
M Source/WebCore/platform/sql/SQLiteDatabase.cpp View 5 chunks +6 lines, -6 lines 0 comments Download
M Source/WebCore/platform/sql/SQLiteStatement.cpp View 1 10 chunks +14 lines, -14 lines 0 comments Download
M Source/WebCore/rendering/RenderLayerCompositor.cpp View 3 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
danakj
7 years, 8 months ago (2013-04-04 14:12:18 UTC) #1
eseidel
On 2013/04/04 14:12:18, danakj wrote: I'm OK with this idea. Do you have a proposal ...
7 years, 8 months ago (2013-04-04 14:36:23 UTC) #2
danakj
On 2013/04/04 14:36:23, Eric Seidel (Google) wrote: > On 2013/04/04 14:12:18, danakj wrote: > > ...
7 years, 8 months ago (2013-04-04 14:38:48 UTC) #3
eseidel
It's possible to argue either way as to which LOG should change, but in the ...
7 years, 8 months ago (2013-04-05 04:03:39 UTC) #4
eseidel
lgtm
7 years, 8 months ago (2013-04-05 04:03:52 UTC) #5
abarth-chromium
There are some hacks around #undef LOG that we should unwind once this patch lands.
7 years, 8 months ago (2013-04-05 04:05:19 UTC) #6
eseidel1
7 years ago (2013-11-30 02:02:34 UTC) #7
Message was sent while issue was closed.

          

Powered by Google App Engine
This is Rietveld 408576698