Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1364263002: Remove SkImage::newImage() (Closed)

Created:
5 years, 3 months ago by f(malita)
Modified:
5 years, 3 months ago
Reviewers:
reed1
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Remove SkImage::newImage() All clients converted to newSubset(). R=reed@google.com Committed: https://skia.googlesource.com/skia/+/3f9deab9fc0e0aba77dfa0fe09e7ef01921ce689

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -54 lines) Patch
M include/core/SkImage.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/image/SkImage.cpp View 1 chunk +0 lines, -32 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
f(malita)
5 years, 3 months ago (2015-09-24 14:33:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364263002/1
5 years, 3 months ago (2015-09-24 14:33:16 UTC) #3
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 3 months ago (2015-09-24 14:33:18 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: skia_presubmit-Trybot on client.skia.fyi (JOB_FAILED, http://build.chromium.org/p/client.skia.fyi/builders/skia_presubmit-Trybot/builds/2850)
5 years, 3 months ago (2015-09-24 14:34:19 UTC) #6
reed1
lgtm
5 years, 3 months ago (2015-09-24 14:40:31 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364263002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364263002/1
5 years, 3 months ago (2015-09-24 14:43:09 UTC) #9
commit-bot: I haz the power
5 years, 3 months ago (2015-09-24 14:43:44 UTC) #10
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3f9deab9fc0e0aba77dfa0fe09e7ef01921ce689

Powered by Google App Engine
This is Rietveld 408576698