Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 1364243002: Bundle core applicatons in the shell. (Closed)

Created:
5 years, 3 months ago by qsr
Modified:
5 years, 2 months ago
Reviewers:
etiennej
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Bundle core applicatons in the shell. For release and official build, core mojo applicatons are bundled in the shell. This allows to greatly reduce the time needed for the first run. After this, application are updated from the network. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/c440c74e978ca24f02405dccab9367376bbe3c20

Patch Set 1 #

Total comments: 2

Patch Set 2 : Follow review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+311 lines, -20 lines) Patch
M services/url_response_disk_cache/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.h View 2 chunks +4 lines, -1 line 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_app.cc View 2 chunks +6 lines, -4 lines 0 comments Download
A services/url_response_disk_cache/url_response_disk_cache_delegate.h View 1 chunk +39 lines, -0 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M services/url_response_disk_cache/url_response_disk_cache_impl.cc View 3 chunks +46 lines, -3 lines 0 comments Download
M shell/BUILD.gn View 1 2 chunks +28 lines, -0 lines 0 comments Download
M shell/android/apk/src/org/chromium/mojo/shell/ShellService.java View 4 chunks +7 lines, -3 lines 0 comments Download
M shell/android/main.cc View 5 chunks +12 lines, -1 line 0 comments Download
A shell/android/url_response_disk_cache_delegate_impl.h View 1 chunk +46 lines, -0 lines 0 comments Download
A shell/android/url_response_disk_cache_delegate_impl.cc View 1 chunk +99 lines, -0 lines 0 comments Download
M shell/context.h View 2 chunks +9 lines, -2 lines 0 comments Download
M shell/context.cc View 2 chunks +6 lines, -3 lines 0 comments Download
M shell/url_response_disk_cache_loader.h View 1 chunk +2 lines, -1 line 0 comments Download
M shell/url_response_disk_cache_loader.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
qsr
5 years, 3 months ago (2015-09-24 14:03:57 UTC) #1
etiennej
https://codereview.chromium.org/1364243002/diff/1/shell/BUILD.gn File shell/BUILD.gn (right): https://codereview.chromium.org/1364243002/diff/1/shell/BUILD.gn#newcode404 shell/BUILD.gn:404: sources += [ Here is the list of core ...
5 years, 3 months ago (2015-09-24 14:35:25 UTC) #2
qsr
Ok for window_manager. I'm not completely convinced by the other two, especially for device_info, but ...
5 years, 3 months ago (2015-09-24 14:43:50 UTC) #3
etiennej
lgtm
5 years, 2 months ago (2015-09-28 08:57:49 UTC) #4
qsr
5 years, 2 months ago (2015-09-28 11:52:56 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c440c74e978ca24f02405dccab9367376bbe3c20 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698