Issue 136423002: Merge cl for revision 31552, with update for compiler=none suppression

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136423002: Merge cl for revision 31552, with update for compiler=none suppression (Closed)

Created:
6 years, 11 months ago by ricow1

Modified:
5 years, 3 months ago

Reviewers:
kasperl

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/trunk/dart/

Visibility:
Public.

More Reviews

Description

Merge cl for revision 31552, with update for compiler=none suppression Revision 31552 broadens the suppression for html/audiobuffersourcenode_test to cover non dartium browsers as well (i.e., compiler==dart2js effectively). We actually do not need the supppression for compiler=none since dartium on trunk is not M32, but M31. So in effect, this cls add the suppression for dart2js based bots, bot removes it for compiler=none bots.

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/html/html.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kasperl

LGTM. Update version or land together with another change that updates the version?

6 years, 11 months ago (2014-01-13 10:35:42 UTC) #2

ricow1

6 years, 11 months ago (2014-01-13 10:39:52 UTC) #3

On 2014/01/13 10:35:42, kasperl wrote:
> LGTM. Update version or land together with another change that updates the
> version?

Land together with other stuff, merge request here:
https://code.google.com/p/dart/issues/detail?id=16051

Expand Messages | Collapse Messages