Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 13642007: Rewrite scoped_array<T> to scoped_ptr<T[]> in remoting/, Linux edition. (Closed)

Created:
7 years, 8 months ago by dcheng
Modified:
7 years, 8 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, simonmorris+watch_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, amit, sanjeevr, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, sergeyu+watch_chromium.org
Visibility:
Public.

Description

Rewrite scoped_array<T> to scoped_ptr<T[]> in remoting/, Linux edition. This changelist was automatically generated using a clang tool. BUG=171111 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192873

Patch Set 1 #

Patch Set 2 : Manually rewrite Win files. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -26 lines) Patch
M remoting/base/compound_buffer_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/util.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/base/util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/client/audio_player_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/audio_encoder_opus.h View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/codec/audio_encoder_speex.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/codec_test.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M remoting/codec/video_decoder_verbatim.h View 1 chunk +1 line, -1 line 0 comments Download
M remoting/codec/video_encoder_vp8.h View 1 chunk +2 lines, -2 lines 0 comments Download
M remoting/host/disconnect_window_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/input_injector_linux.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M remoting/host/local_input_monitor_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/plugin/host_script_object.cc View 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/verify_config_window_win.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/elevated_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/host/win/launch_process_with_token.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M remoting/protocol/message_decoder_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
dcheng
7 years, 8 months ago (2013-04-06 06:14:39 UTC) #1
alexeypa (please no reviews)
lgtm, once the Windows-only files in src/remoting are updated as well. scoped_array is used in: ...
7 years, 8 months ago (2013-04-08 15:52:20 UTC) #2
dcheng
I was actually going to make a followup patch to remove all residual references to ...
7 years, 8 months ago (2013-04-08 18:02:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dcheng@chromium.org/13642007/6001
7 years, 8 months ago (2013-04-08 18:03:07 UTC) #4
commit-bot: I haz the power
Retried try job too often on mac_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&number=115979
7 years, 8 months ago (2013-04-08 19:54:18 UTC) #5
dcheng
7 years, 8 months ago (2013-04-08 20:13:46 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r192873 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698