sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart - Issue 13642002: Make sure required type arguments are given when using factories.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 13642002: Make sure required type arguments are given when using factories. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Address comments. Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/enqueue.dart ('k') | sdk/lib/_internal/compiler/implementation/js_backend/runtime_types.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

diff --git a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

index 1a25d7328ffb7b32e8c73a03e89a8ffd9d40b62c..b2ad0686849ba4ab0dd2c63c6b335a1026f6048b 100644

--- a/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

+++ b/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

@@ -142,7 +142,8 @@ class CodeEmitterTask extends CompilerTask {

void computeRequiredTypeChecks() {

assert(checkedClasses == null && checkedTypedefs == null);

- compiler.codegenWorld.addImplicitChecks(classesUsingTypeVariableTests);

+ backend.rti.addImplicitChecks(compiler.codegenWorld,

+ classesUsingTypeVariableTests);

checkedClasses = new Set<ClassElement>();

checkedTypedefs = new Set<TypedefElement>();