Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1364183004: Fix remote_adb_setup with new `pub run sky_tools run_mojo` command. (Closed)

Created:
5 years, 3 months ago by tonyg
Modified:
5 years, 2 months ago
Reviewers:
qsr
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Fix remote_adb_setup with new `pub run sky_tools run_mojo` command. It uses a different port. BUG= R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/03531a0bcb322e0736eed66b091d200d6bb500f7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M mojo/devtools/common/remote_adb_setup View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
tonyg
5 years, 3 months ago (2015-09-24 13:44:33 UTC) #2
qsr
lgtm
5 years, 3 months ago (2015-09-24 13:45:38 UTC) #3
charlieloveeric3
<deployment> <exclude-subsystems> <subsystem name="jpa"/> </exclude-subsystems> <exclusions> <module name="javaee.api"/> <module name="org.apache.commons.logging"/> <module name="org.slf4j"/> <module name="org.slf4j.impl"/> <module ...
5 years, 3 months ago (2015-09-24 13:46:12 UTC) #5
tonyg
5 years, 3 months ago (2015-09-24 13:46:36 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
03531a0bcb322e0736eed66b091d200d6bb500f7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698