Issue 1364183004: Fix remote_adb_setup with new `pub run sky_tools run_mojo` command.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1364183004: Fix remote_adb_setup with new `pub run sky_tools run_mojo` command. (Closed)

Created:
5 years, 3 months ago by tonyg

Modified:
5 years, 2 months ago

Reviewers:
qsr

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Fix remote_adb_setup with new `pub run sky_tools run_mojo` command. It uses a different port. BUG= R=qsr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/03531a0bcb322e0736eed66b091d200d6bb500f7

Patch Set 1 #

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -1 line)			Patch
	M	mojo/devtools/common/remote_adb_setup	View		1 chunk	+3 lines, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

charlieloveeric3

<deployment> <exclude-subsystems> <subsystem name="jpa"/> </exclude-subsystems> <exclusions> <module name="javaee.api"/> <module name="org.apache.commons.logging"/> <module name="org.slf4j"/> <module name="org.slf4j.impl"/> <module ...

5 years, 3 months ago (2015-09-24 13:46:12 UTC) #5

tonyg

5 years, 3 months ago (2015-09-24 13:46:36 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
03531a0bcb322e0736eed66b091d200d6bb500f7 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages