chrome/browser/resources/pdf/toolbar_manager.js - Issue 1364163002: Material PDF: Support RTL languages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/pdf/toolbar_manager.js

Issue 1364163002: Material PDF: Support RTL languages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use reflectToAttribute Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/pdf/toolbar_manager.js

diff --git a/chrome/browser/resources/pdf/toolbar_manager.js b/chrome/browser/resources/pdf/toolbar_manager.js

index a9c9c36e2b378b20af28446efad61d40561e47f8..08f2f5a49c57a23b97d21751b61304859a48235c 100644

--- a/chrome/browser/resources/pdf/toolbar_manager.js

+++ b/chrome/browser/resources/pdf/toolbar_manager.js

@@ -42,7 +42,9 @@ function isMouseNearTopToolbar(e) {

* screen.

function isMouseNearSideToolbar(e) {

- return e.x > window.innerWidth - SIDE_TOOLBAR_REVEAL_DISTANCE_RIGHT &&

+ return (document.dir == 'rtl' ?

+ e.x < SIDE_TOOLBAR_REVEAL_DISTANCE_RIGHT :

+ e.x > window.innerWidth - SIDE_TOOLBAR_REVEAL_DISTANCE_RIGHT) &&

raymes 2015/09/28 03:14:53 nit: split into multiple statements.

tsergeant 2015/09/28 04:26:34 Done.

e.y > window.innerHeight - SIDE_TOOLBAR_REVEAL_DISTANCE_BOTTOM;

}