Material PDF: Support RTL languages

chrome/browser/resources/pdf/pdf.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 'use strict';
 
 /**
  * @return {number} Width of a scrollbar in pixels
  */
 function getScrollbarWidth() {
@@ skipping 551 matching lines @@
    * chrome.resourcesPrivate.
    * @param {Object} strings Dictionary of translated strings
    */
   handleStrings_: function(strings) {
     if (this.isMaterial_) {
       this.errorScreen_.strings = strings;
       this.passwordScreen_.strings = strings;
       if (this.materialToolbar_)
         this.materialToolbar_.strings = strings;
       this.zoomToolbar_.strings = strings;
+      document.dir = strings['textdirection'];
+      document.lang = strings['language'];
     } else {
       this.passwordScreen_.text = strings.passwordPrompt;
       this.progressBar_.text = strings.pageLoading;
       if (!this.isPrintPreview_)
         this.progressBar_.style.visibility = 'visible';
       this.errorScreen_.text = strings.pageLoadFailed;
     }
   },
 
   /**
@@ skipping 159 matching lines @@
     var scrollbarWidth = this.viewport_.scrollbarWidth;
     var verticalScrollbarWidth = hasScrollbars.vertical ? scrollbarWidth : 0;
     var horizontalScrollbarWidth =
         hasScrollbars.horizontal ? scrollbarWidth : 0;
     if (this.isMaterial_) {
       // Shift the zoom toolbar to the left by half a scrollbar width. This
       // gives a compromise: if there is no scrollbar visible then the toolbar
       // will be half a scrollbar width further left than the spec but if there
       // is a scrollbar visible it will be half a scrollbar width further right
       // than the spec.
-      this.zoomToolbar_.style.right = -verticalScrollbarWidth +
-          (scrollbarWidth / 2) + 'px';
+      if (document.dir == 'ltr')

[raymes, 2015/09/28 03:14:53]

nit: add comment about why this is the case
add {} because it's a multiline if

[tsergeant, 2015/09/28 04:26:33]

Done

+        this.zoomToolbar_.style.right = -verticalScrollbarWidth +
+            (scrollbarWidth / 2) + 'px';
       // Having a horizontal scrollbar is much rarer so we don't offset the
       // toolbar from the bottom any more than what the spec says. This means
       // that when there is a scrollbar visible, it will be a full scrollbar
       // width closer to the bottom of the screen than usual, but this is ok.
       this.zoomToolbar_.style.bottom = -horizontalScrollbarWidth + 'px';
     } else {
       var toolbarRight = Math.max(PDFViewer.MIN_TOOLBAR_OFFSET, scrollbarWidth);
       var toolbarBottom =
           Math.max(PDFViewer.MIN_TOOLBAR_OFFSET, scrollbarWidth);
       toolbarRight -= verticalScrollbarWidth;
@@ skipping 158 matching lines @@
    * Each bookmark is an Object containing a:
    * - title
    * - page (optional)
    * - array of children (themselves bookmarks)
    * @type {Array} the top-level bookmarks of the PDF.
    */
   get bookmarks() {
     return this.bookmarks_;
   }
 };