Issue 136413003: Deprecate ScriptData::PreCompile which takes const char*.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 136413003: Deprecate ScriptData::PreCompile which takes const char*. (Closed)

Created:
6 years, 11 months ago by marja

Modified:
6 years, 11 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Remove ScriptData::PreCompile which takes const char*. The version taking a Handle should be used instead. It's not used by Chromium and complicates the ongoing lexer work. R=svenpanne@chromium.org BUG= Committed: https://code.google.com/p/v8/source/detail?r=18556

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -75 lines)			Patch
M	include/v8.h	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	src/api.cc	View	1	1 chunk	+0 lines, -10 lines	0 comments	Download
M	test/cctest/test-api.cc	View		7 chunks	+12 lines, -47 lines	0 comments	Download
M	test/cctest/test-parsing.cc	View		3 chunks	+16 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

marja

6 years, 11 months ago (2014-01-13 10:51:47 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r18556 (presubmit successful).