Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(871)

Unified Diff: chrome/browser/ui/webui/options/clear_browser_data_handler.h

Issue 1364103007: Simplify the support string in the Clear Browsing Data dialog. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed comments. Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/options/clear_browser_data_handler.h
diff --git a/chrome/browser/ui/webui/options/clear_browser_data_handler.h b/chrome/browser/ui/webui/options/clear_browser_data_handler.h
index 7ffe94918f669dd62fe49ba008a5ffbddebb85d5..3c6ec324347171af7a3b2c3d8199d84adc03aa3e 100644
--- a/chrome/browser/ui/webui/options/clear_browser_data_handler.h
+++ b/chrome/browser/ui/webui/options/clear_browser_data_handler.h
@@ -9,13 +9,15 @@
#include "base/prefs/pref_member.h"
#include "chrome/browser/browsing_data/browsing_data_counter.h"
#include "chrome/browser/browsing_data/browsing_data_remover.h"
+#include "chrome/browser/sync/profile_sync_service.h"
#include "chrome/browser/ui/webui/options/options_ui.h"
namespace options {
// Clear browser data handler page UI handler.
class ClearBrowserDataHandler : public OptionsPageUIHandler,
- public BrowsingDataRemover::Observer {
+ public BrowsingDataRemover::Observer,
+ public sync_driver::SyncServiceObserver {
public:
ClearBrowserDataHandler();
~ClearBrowserDataHandler() override;
@@ -54,6 +56,10 @@ class ClearBrowserDataHandler : public OptionsPageUIHandler,
bool finished,
uint32 count);
+ // Implementation of SyncServiceObserver. Updates the support string at the
+ // bottom of the dialog.
+ void OnStateChanged() override;
+
// If non-null it means removal is in progress. BrowsingDataRemover takes care
// of deleting itself when done.
BrowsingDataRemover* remover_;
@@ -71,6 +77,9 @@ class ClearBrowserDataHandler : public OptionsPageUIHandler,
// Counters that calculate the data volume for some of the data types.
ScopedVector<BrowsingDataCounter> counters_;
+ // Informs us whether the user is syncing their data.
+ ProfileSyncService* sync_service_;
+
DISALLOW_COPY_AND_ASSIGN(ClearBrowserDataHandler);
};

Powered by Google App Engine
This is Rietveld 408576698