Simplify the support string in the Clear Browsing Data dialog.

chrome/browser/resources/options/clear_browser_data_overlay.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
 
   /**
    * ClearBrowserDataOverlay class
@@ skipping 53 matching lines @@
       types.forEach(function(type) {
           Preferences.getInstance().addEventListener(type, f);
       });
 
       var checkboxes = document.querySelectorAll(
           '#cbd-content-area input[type=checkbox]');
       for (var i = 0; i < checkboxes.length; i++) {
         checkboxes[i].onclick = f;
       }
 
-      this.createStuffRemainsFooter_();
-
       $('clear-browser-data-dismiss').onclick = function(event) {
         ClearBrowserDataOverlay.dismiss();
       };
       $('clear-browser-data-commit').onclick = function(event) {
         ClearBrowserDataOverlay.setClearing(true);
         chrome.send('performClearBrowserData');
       };
 
       // For managed profiles, hide the checkboxes controlling whether or not
       // browsing and download history should be cleared. Note that this is
       // different than just disabling them as a result of enterprise policies.
       if (!loadTimeData.getBoolean('showDeleteBrowsingHistoryCheckboxes')) {
         $('delete-browsing-history-container').hidden = true;
         $('delete-download-history-container').hidden = true;
       }
 
       this.updateStateOfControls_();
     },
 
     /**
      * Create a footer that explains that some content is not cleared by the
-     * clear browsing history dialog.
+     * clear browsing data dialog and warns that the deletion may be synced.
+     * @param {boolean} simple Whether to use a simple support string.
+     * @param {boolean} syncing Whether the user uses Sync.
+     * @private
      */
-    createStuffRemainsFooter_: function() {
+    createFooter_: function(simple, syncing) {
       // The localized string is of the form "Saved [content settings] and
       // {search engines} will not be cleared and may reflect your browsing
-      // habits.". The following parses out the parts in brackts and braces and
-      // converts them into buttons whereas the remainders are represented as
-      // span elements.
+      // habits.", or of the form "Some settings that may reflect browsing
+      // habits |will not be cleared|." if the simplified support string
+      // experiment is enabled. The following parses out the parts in brackets
+      // and braces and converts them into buttons whereas the remainders are
+      // represented as span elements.
       var footer =
           document.querySelector('#some-stuff-remains-footer p');
       var footerFragments =
-          loadTimeData.getString('contentSettingsAndSearchEnginesRemain')
+          loadTimeData.getString('clearBrowserDataSupportString')
                       .split(/([|#])/);
+
+      if (simple) {
+        footerFragments.unshift(
+            loadTimeData.getString('clearBrowserDataSyncWarning') +
+            ' ' // Padding between the sync warning and the rest of the footer.

[Bernhard Bauer, 2015/09/26 06:46:07]

Nit: Two spaces before comments.

[msramek, 2015/09/28 08:41:41]

Done. The JS linter seemed to be pretty aggressive, weird that it missed this.

+        );
+      }
+
       for (var i = 0; i < footerFragments.length;) {
         var linkId = '';
         if (i + 2 < footerFragments.length) {
           if (footerFragments[i] == '|' && footerFragments[i + 2] == '|') {
-            linkId = 'open-content-settings-from-clear-browsing-data';
+            if (simple)
+              linkId = 'open-not-deleted-help-from-clear-browsing-data';
+            else
+              linkId = 'open-content-settings-from-clear-browsing-data';
           } else if (footerFragments[i] == '#' &&
                      footerFragments[i + 2] == '#') {
             linkId = 'open-search-engines-from-clear-browsing-data';
           }
         }
 
         if (linkId) {
           var link = new ActionLink;
           link.id = linkId;
           link.textContent = footerFragments[i + 1];
           footer.appendChild(link);
           i += 3;
         } else {
           var span = document.createElement('span');
           span.textContent = footerFragments[i];
+          if (simple && i == 0) {
+            span.id = 'clear-browser-data-sync-warning';
+            span.hidden = !syncing;
+          }
           footer.appendChild(span);
           i += 1;
         }
       }
-      $('open-content-settings-from-clear-browsing-data').onclick =
-          function(event) {
-        PageManager.showPageByName('content');
-      };
-      $('open-search-engines-from-clear-browsing-data').onclick =
-          function(event) {
-        PageManager.showPageByName('searchEngines');
-      };
+
+      if (simple) {
+        $('open-not-deleted-help-from-clear-browsing-data').onclick =
+            function(event) {
+          // TODO(msramek): Link to the exact page when the article is written.
+          window.open('https://support.google.com/chrome/');
+        };
+      } else {
+        $('open-content-settings-from-clear-browsing-data').onclick =
+            function(event) {
+          PageManager.showPageByName('content');
+        };
+        $('open-search-engines-from-clear-browsing-data').onclick =
+            function(event) {
+          PageManager.showPageByName('searchEngines');
+        };
+      }
     },
 
     /**
+     * Shows or hides the sync warning based on whether the user uses Sync.
+     * @param {boolean} syncing Whether the user uses Sync.
+     * @private
+     */
+    updateSyncWarning_: function(syncing) {
+      $('clear-browser-data-sync-warning').hidden = !syncing;
+    },
+
+    /**
      * Sets whether or not we are in the process of clearing data.
      * @param {boolean} clearing Whether the browsing data is currently being
      *     cleared.
      * @private
      */
     setClearing_: function(clearing) {
       this.isClearingInProgress_ = clearing;
       this.updateStateOfControls_();
     },
 
@@ skipping 85 matching lines @@
   // Chrome callbacks
   //
   ClearBrowserDataOverlay.setAllowDeletingHistory = function(allowed) {
     ClearBrowserDataOverlay.getInstance().setAllowDeletingHistory_(allowed);
   };
 
   ClearBrowserDataOverlay.updateCounter = function(pref_name, text) {
     ClearBrowserDataOverlay.getInstance().updateCounter_(pref_name, text);
   };
 
+  ClearBrowserDataOverlay.createFooter = function(simple, syncing) {
+    ClearBrowserDataOverlay.getInstance().createFooter_(simple, syncing);
+  };
+
+  ClearBrowserDataOverlay.updateSyncWarning = function(syncing) {
+    ClearBrowserDataOverlay.getInstance().updateSyncWarning_(syncing);
+  };
+
   ClearBrowserDataOverlay.setClearing = function(clearing) {
     ClearBrowserDataOverlay.getInstance().setClearing_(clearing);
   };
 
   ClearBrowserDataOverlay.markInitializationComplete = function() {
     ClearBrowserDataOverlay.getInstance().markInitializationComplete_();
   };
 
   ClearBrowserDataOverlay.setBannerText = function(text) {
     $('clear-browser-data-info-banner').innerText = text;
@@ skipping 13 matching lines @@
     var topmostVisiblePage = PageManager.getTopmostVisiblePage();
     if (topmostVisiblePage && topmostVisiblePage.name == 'clearBrowserData')
       PageManager.closeOverlay();
   };
 
   // Export
   return {
     ClearBrowserDataOverlay: ClearBrowserDataOverlay
   };
 });