Simplify the support string in the Clear Browsing Data dialog.

Simplify the support string in the Clear Browsing Data dialog.

Instead of enumerating items that will not be deleted, link to a help center article that will give more details. The article has yet to be written, but the code can be already put in place.

This CL introduces a flag to guard this change, and implements it on desktop. Android and iOS implementations are to come in later CLs.

BUG=535890
Committed: https://crrev.com/8d78c8044e418d86d3d257ac916ce1f32936534f
Cr-Commit-Position: refs/heads/master@{#351049}

[msramek, 2015-09-25 15:42:30]

Patchset #1 (id:1) has been deleted

[msramek, 2015-09-25 15:49:16]

msramek@chromium.org changed reviewers:
+ bauerb@chromium.org

[msramek, 2015-09-25 15:49:17]

Hi Bernhard,

could you please have a look at this? This is a part of the plans that we have
for revamping the CBD dialog; it was supposed to be launched together with a lot
of other changes, but the linked bug explains why it would be nice to have it
sooner.

Thanks,
Martin

[msramek, 2015-09-25 15:49:58]

+Ilya, please review histograms.xml.

[msramek, 2015-09-25 15:50:38]

msramek@chromium.org changed reviewers:
+ isherman@chromium.org

[Ilya Sherman, 2015-09-26 00:21:35]

histograms.xml lgtm

[Bernhard Bauer, 2015-09-26 06:46:08]

LGTM w/ nits:

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/clear_browser_data_overlay.js (right):

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/clear_browser_data_overlay.js:117: ' ' //
Padding between the sync warning and the rest of the footer.
Nit: Two spaces before comments.

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:58:
sync_service_(NULL) {
Prefer nullptr over NULL (the line above as well if you're already touching code
here).

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/clear_browser_data_handler.h (right):

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/clear_browser_data_handler.h:59: // Called when
the Sync service state changes. Updates the support string
Mention which interface this method implements? Then you don't have to mention
when the method is called, as that should be the comment for the pure virtual
method in the interface (but you can keep the comment that says what this
particular implementation does).

[msramek, 2015-09-28 08:41:42]

Thanks, guys!

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/resource...
File chrome/browser/resources/options/clear_browser_data_overlay.js (right):

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/resource...
chrome/browser/resources/options/clear_browser_data_overlay.js:117: ' ' //
Padding between the sync warning and the rest of the footer.
On 2015/09/26 06:46:07, Bernhard (slow until Sep 28) wrote:
> Nit: Two spaces before comments.

Done. The JS linter seemed to be pretty aggressive, weird that it missed this.

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/clear_browser_data_handler.cc (right):

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/clear_browser_data_handler.cc:58:
sync_service_(NULL) {
On 2015/09/26 06:46:07, Bernhard (slow until Sep 28) wrote:
> Prefer nullptr over NULL (the line above as well if you're already touching
code
> here).

Done.

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/clear_browser_data_handler.h (right):

https://codereview.chromium.org/1364103007/diff/20001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/clear_browser_data_handler.h:59: // Called when
the Sync service state changes. Updates the support string
On 2015/09/26 06:46:07, Bernhard (slow until Sep 28) wrote:
> Mention which interface this method implements? Then you don't have to mention
> when the method is called, as that should be the comment for the pure virtual
> method in the interface (but you can keep the comment that says what this
> particular implementation does).

Done.

[msramek, 2015-09-28 08:41:45]

The CQ bit was checked by msramek@chromium.org

[msramek, 2015-09-28 08:41:46]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org,
isherman@chromium.org
Link to the patchset: https://codereview.chromium.org/1364103007/#ps40001
(title: "Addressed comments.")

[commit-bot: I haz the power, 2015-09-28 08:42:38]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1364103007/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1364103007/40001

[commit-bot: I haz the power, 2015-09-28 09:49:11]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2015-09-28 09:50:37]

Patchset 2 (id:??) landed as
https://crrev.com/8d78c8044e418d86d3d257ac916ce1f32936534f
Cr-Commit-Position: refs/heads/master@{#351049}