third_party/WebKit/Source/core/layout/LayoutView.cpp - Issue 1364063007: Throttle rendering pipeline for invisible frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutView.cpp

Issue 1364063007: Throttle rendering pipeline for invisible frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix layout test by not dumping throttled FrameViews. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutView.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutView.cpp b/third_party/WebKit/Source/core/layout/LayoutView.cpp

index 85951eeac95cb28c184177691aec2a62cc8ea4a1..eea396a633fef1a2a4c58709cbe9bb466ebb6100 100644

--- a/third_party/WebKit/Source/core/layout/LayoutView.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutView.cpp

@@ -87,6 +87,7 @@ bool LayoutView::hitTest(HitTestResult& result)

// into a child document, it could trigger a layout on the parent document, which can destroy PaintLayer

// that are higher up in the call stack, leading to crashes.

// Note that Document::updateLayout calls its parent's updateLayout.

+ DocumentLifecycle::PreventThrottlingScope preventThrottling(document().lifecycle());

frameView()->updateLifecycleToCompositingCleanPlusScrolling();

return hitTestNoLifecycleUpdate(result);

}