Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(497)

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1364063007: Throttle rendering pipeline for invisible frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix layout test by not dumping throttled FrameViews. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/Document.cpp
diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp
index 678da0aecf4cc7640ea50c58b35b4c6eb0cb1c1a..5e6656a216a2240f2cc68328dbc497717ec4524c 100644
--- a/third_party/WebKit/Source/core/dom/Document.cpp
+++ b/third_party/WebKit/Source/core/dom/Document.cpp
@@ -1531,7 +1531,8 @@ void Document::scheduleLayoutTreeUpdate()
ASSERT(shouldScheduleLayoutTreeUpdate());
ASSERT(needsLayoutTreeUpdate());
- page()->animator().scheduleVisualUpdate();
+ if (!view()->shouldThrottleRendering())
+ page()->animator().scheduleVisualUpdate();
m_lifecycle.ensureStateAtMost(DocumentLifecycle::VisualUpdatePending);
TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ScheduleStyleRecalculation", TRACE_EVENT_SCOPE_THREAD, "data", InspectorRecalculateStylesEvent::data(frame()));
@@ -1721,6 +1722,9 @@ void Document::updateLayoutTree(StyleRecalcChange change)
if (!view() || !isActive())
return;
+ if (view()->shouldThrottleRendering())
+ return;
+
if (change != Force && !needsLayoutTreeUpdate()) {
ASSERT(lifecycle().state() != DocumentLifecycle::VisualUpdatePending);
return;
@@ -1788,6 +1792,9 @@ void Document::updateLayoutTree(StyleRecalcChange change)
void Document::updateStyle(StyleRecalcChange change)
{
+ if (view()->shouldThrottleRendering())
+ return;
+
TRACE_EVENT_BEGIN0("blink,blink_style", "Document::updateStyle");
unsigned initialResolverAccessCount = styleEngine().resolverAccessCount();
@@ -1965,6 +1972,7 @@ void Document::clearFocusedElementTimerFired(Timer<Document>*)
// to instead suspend JavaScript execution.
void Document::updateLayoutIgnorePendingStylesheets(Document::RunPostLayoutTasks runPostLayoutTasks)
{
+ DocumentLifecycle::PreventThrottlingScope preventThrottling(lifecycle());
StyleEngine::IgnoringPendingStylesheet ignoring(styleEngine());
if (styleEngine().hasPendingSheets()) {

Powered by Google App Engine
This is Rietveld 408576698