third_party/WebKit/Source/core/dom/Document.cpp - Issue 1364063007: Throttle rendering pipeline for invisible frames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/Document.cpp

Issue 1364063007: Throttle rendering pipeline for invisible frames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Might help to include the test source code. Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/render_widget.cc ('k') | third_party/WebKit/Source/core/dom/DocumentLifecycle.h » ('j') | third_party/WebKit/Source/web/tests/FrameThrottlingTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/Document.cpp

diff --git a/third_party/WebKit/Source/core/dom/Document.cpp b/third_party/WebKit/Source/core/dom/Document.cpp

index dff02f7249fa660d7e136ddbdfd24c7ad473be35..482f24aed3fda37514eac065e6acefc2aca9130e 100644

--- a/third_party/WebKit/Source/core/dom/Document.cpp

+++ b/third_party/WebKit/Source/core/dom/Document.cpp

@@ -1526,7 +1526,8 @@ void Document::scheduleLayoutTreeUpdate()

ASSERT(shouldScheduleLayoutTreeUpdate());

ASSERT(needsLayoutTreeUpdate());

- page()->animator().scheduleVisualUpdate();

+ if (!view() || !view()->shouldThrottleRenderingPipeline())

+ page()->animator().scheduleVisualUpdate();

m_lifecycle.ensureStateAtMost(DocumentLifecycle::VisualUpdatePending);

TRACE_EVENT_INSTANT1(TRACE_DISABLED_BY_DEFAULT("devtools.timeline"), "ScheduleStyleRecalculation", TRACE_EVENT_SCOPE_THREAD, "data", InspectorRecalculateStylesEvent::data(frame()));