Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(390)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1364043003: Move status bar color setting to ChromeActivity. (Closed)

Created:
5 years, 3 months ago by aurimas (slooooooooow)
Modified:
4 years, 3 months ago
Reviewers:
Ted C, Yusuf
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Move status bar color setting to ChromeActivity. BUG=535235 Committed: https://crrev.com/4b74179f72ea6c4f0b1539a8c31277e8d29f7711 Cr-Commit-Position: refs/heads/master@{#350961}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move tab check #

Total comments: 1

Patch Set 3 : Fix tab switcher #

Patch Set 4 : Add java dock #

Patch Set 5 : Add javadoc #

Messages

Total messages: 15 (6 generated)
aurimas (slooooooooow)
PTAL
5 years, 3 months ago (2015-09-23 21:59:45 UTC) #2
Yusuf
lgtm with a nit https://codereview.chromium.org/1364043003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://codereview.chromium.org/1364043003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode522 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:522: if (getActivityTab() != tab) return; ...
5 years, 3 months ago (2015-09-24 04:54:16 UTC) #3
aurimas (slooooooooow)
+tedchoc for OWNERS review https://chromiumcodereview.appspot.com/1364043003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java File chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java (right): https://chromiumcodereview.appspot.com/1364043003/diff/1/chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java#newcode522 chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java:522: if (getActivityTab() != tab) return; ...
5 years, 3 months ago (2015-09-24 21:16:41 UTC) #4
aurimas (slooooooooow)
actually +tedchoc for OWNERS review this time.
5 years, 3 months ago (2015-09-25 01:28:33 UTC) #6
Ted C
lgtm https://chromiumcodereview.appspot.com/1364043003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java File chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java (right): https://chromiumcodereview.appspot.com/1364043003/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java#newcode3214 chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java:3214: public int getDefaultThemeColor() { javadoc
5 years, 2 months ago (2015-09-25 17:47:19 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1364043003/70001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1364043003/70001
5 years, 2 months ago (2015-09-26 00:04:30 UTC) #10
commit-bot: I haz the power
Committed patchset #5 (id:70001)
5 years, 2 months ago (2015-09-26 00:51:04 UTC) #11
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/4b74179f72ea6c4f0b1539a8c31277e8d29f7711 Cr-Commit-Position: refs/heads/master@{#350961}
5 years, 2 months ago (2015-09-26 00:51:40 UTC) #12
Benoit L
5 years, 2 months ago (2015-09-28 09:11:54 UTC) #13
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:70001) has been created in
https://codereview.chromium.org/1372883002/ by lizeb@chromium.org.

The reason for reverting is: Broke CustomTabActivityTest#testToolbarColor, see
crbug.com/536698 for the tracking bug, and crrev.com/1370003002 for a potential
fix..

Powered by Google App Engine
This is Rietveld 408576698