Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 13640007: devirtualize Parser (Closed)

Created:
7 years, 8 months ago by wingo
Modified:
7 years, 8 months ago
Reviewers:
Michael Starzinger
CC:
rossberg
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Devirtualize Parser * src/parser.h: No one inherits from Parser, so the destructor can be non-virtual, removing the need for Parser to have a vtable. Also add BASE_EMBEDDED to it and to RegExpParser. BUG= Committed: http://code.google.com/p/v8/source/detail?r=14162

Patch Set 1 #

Total comments: 2

Patch Set 2 : use BASE_EMBEDDED for Parser and also RegExpParser #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M src/parser.h View 1 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
wingo
7 years, 8 months ago (2013-04-04 15:57:32 UTC) #1
Michael Starzinger
LGTM if one comment is addressed. https://codereview.chromium.org/13640007/diff/1/src/parser.h File src/parser.h (right): https://codereview.chromium.org/13640007/diff/1/src/parser.h#newcode426 src/parser.h:426: class Parser { ...
7 years, 8 months ago (2013-04-08 11:07:04 UTC) #2
wingo
Thanks for the review. https://codereview.chromium.org/13640007/diff/1/src/parser.h File src/parser.h (right): https://codereview.chromium.org/13640007/diff/1/src/parser.h#newcode426 src/parser.h:426: class Parser { On 2013/04/08 ...
7 years, 8 months ago (2013-04-08 11:36:52 UTC) #3
Michael Starzinger
I'll land this.
7 years, 8 months ago (2013-04-08 11:49:40 UTC) #4
Michael Starzinger
7 years, 8 months ago (2013-04-08 11:53:58 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r14162 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698