Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 1363993007: DevTools: remove UISourceCode.networkURL (Closed)

Created:
5 years, 2 months ago by pfeldman
Modified:
5 years, 2 months ago
Reviewers:
dgozman
CC:
blink-reviews, yurys, pfeldman, devtools-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: remove UISourceCode.networkURL BUG=456547 Committed: https://crrev.com/52df59226f974509f6910d3e36d14bcb4ca7c5e2 Cr-Commit-Position: refs/heads/master@{#350857}

Patch Set 1 #

Total comments: 1

Patch Set 2 : review comments addressed #

Patch Set 3 : rebaselined #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -71 lines) Patch
M third_party/WebKit/LayoutTests/http/tests/inspector/workspace-test.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/scripts-panel.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/sources/debugger-ui/ui-source-code.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/uisourcecode-revisions.html View 6 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/workspace-mapping.html View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/CompilerScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/ContentProviderBasedProjectDelegate.js View 2 chunks +3 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/DefaultScriptMapping.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/FileSystemWorkspaceBinding.js View 7 chunks +6 lines, -14 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js View 1 3 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/bindings/NetworkProject.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/main/Main.js View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/snippets/ScriptSnippetModel.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/ScriptFormatterEditorAction.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/devtools/front_end/sources/SourcesPanel.js View 1 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/UISourceCode.js View 1 2 4 chunks +4 lines, -18 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/workspace/Workspace.js View 6 chunks +7 lines, -10 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
pfeldman
5 years, 2 months ago (2015-09-24 23:52:48 UTC) #2
dgozman
lgtm https://codereview.chromium.org/1363993007/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js File third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js (right): https://codereview.chromium.org/1363993007/diff/1/third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js#newcode118 third_party/WebKit/Source/devtools/front_end/bindings/NetworkMapping.js:118: var fileSystemPath = fileSystemWorkspaceBinding.fileSystemPath(uiSourceCode.project().id()); Use this._fswb version.
5 years, 2 months ago (2015-09-25 00:29:19 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363993007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363993007/40001
5 years, 2 months ago (2015-09-25 14:23:17 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/112367)
5 years, 2 months ago (2015-09-25 15:42:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363993007/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363993007/40001
5 years, 2 months ago (2015-09-25 16:33:19 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 2 months ago (2015-09-25 17:29:27 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-09-25 17:31:13 UTC) #12
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/52df59226f974509f6910d3e36d14bcb4ca7c5e2
Cr-Commit-Position: refs/heads/master@{#350857}

Powered by Google App Engine
This is Rietveld 408576698