Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1375)

Unified Diff: content/browser/indexed_db/indexed_db_browsertest.cc

Issue 1363993003: Indexed DB: Ship getAll() and friends (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Drop unneeded ExpermentalAPIs test subclass Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/indexed_db/indexed_db_browsertest.cc
diff --git a/content/browser/indexed_db/indexed_db_browsertest.cc b/content/browser/indexed_db/indexed_db_browsertest.cc
index c8ff36f87bbbff2aab1f9bd5de2b0701323ead9c..f4c949a4b77970d6fd95fb784a95854264535803 100644
--- a/content/browser/indexed_db/indexed_db_browsertest.cc
+++ b/content/browser/indexed_db/indexed_db_browsertest.cc
@@ -47,7 +47,8 @@ namespace content {
// This browser test is aimed towards exercising the IndexedDB bindings and
// the actual implementation that lives in the browser side.
-class IndexedDBBrowserTest : public ContentBrowserTest {
+class IndexedDBBrowserTest : public ContentBrowserTest,
+ public ::testing::WithParamInterface<const char*> {
public:
IndexedDBBrowserTest() : disk_usage_(-1) {}
@@ -187,16 +188,6 @@ class IndexedDBBrowserTest : public ContentBrowserTest {
DISALLOW_COPY_AND_ASSIGN(IndexedDBBrowserTest);
};
-class IndexedDBBrowserTestWithExperimentalAPIs
- : public IndexedDBBrowserTest,
- public ::testing::WithParamInterface<const char*> {
- public:
- void SetUpCommandLine(base::CommandLine* command_line) override {
- command_line->AppendSwitch(
- switches::kEnableExperimentalWebPlatformFeatures);
- }
-};
-
IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CursorTest) {
SimpleTest(GetTestUrl("indexeddb", "cursor_test.html"));
}
@@ -242,8 +233,7 @@ IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, CallbackAccounting) {
SimpleTest(GetTestUrl("indexeddb", "callback_accounting.html"));
}
-IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTestWithExperimentalAPIs,
- GetAllMaxMessageSize) {
+IN_PROC_BROWSER_TEST_F(IndexedDBBrowserTest, GetAllMaxMessageSize) {
SimpleTest(GetTestUrl("indexeddb", "getall_max_message_size.html"));
}
@@ -701,11 +691,7 @@ static scoped_ptr<net::test_server::HttpResponse> CorruptDBRequestHandler(
} // namespace
-// Experimental for IDBObjectStore.getAll()
-using IndexedDBBrowserCorruptionTest = IndexedDBBrowserTestWithExperimentalAPIs;
-
-IN_PROC_BROWSER_TEST_P(IndexedDBBrowserCorruptionTest,
- OperationOnCorruptedOpenDatabase) {
+IN_PROC_BROWSER_TEST_P(IndexedDBBrowserTest, OperationOnCorruptedOpenDatabase) {
ASSERT_TRUE(embedded_test_server()->Started() ||
embedded_test_server()->InitializeAndWaitUntilReady());
const GURL& origin_url = embedded_test_server()->base_url();
@@ -724,8 +710,8 @@ IN_PROC_BROWSER_TEST_P(IndexedDBBrowserCorruptionTest,
SimpleTest(embedded_test_server()->GetURL(test_file));
}
-INSTANTIATE_TEST_CASE_P(IndexedDBBrowserCorruptionTestInstantiation,
- IndexedDBBrowserCorruptionTest,
+INSTANTIATE_TEST_CASE_P(IndexedDBBrowserTestInstantiation,
+ IndexedDBBrowserTest,
::testing::Values("failGetBlobJournal",
"get",
"getAll",
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/virtual/stable/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698