third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp - Issue 1363913004: [Reland] Invalidate whitespace text on text color changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

Issue 1363913004: [Reland] Invalidate whitespace text on text color changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutText.h ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGInlineText.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

index 8b8a7695c9f8d7b8659df18e1cc7c311543c66e1..923f251605d6323c7a4f9073b89dadc1ddb8d5d3 100644

--- a/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutTreeAsText.cpp

@@ -194,7 +194,7 @@ void LayoutTreeAsText::writeLayoutObject(TextStream& ts, const LayoutObject& o,

const LayoutText& text = toLayoutText(o);

IntRect linesBox = text.linesBoundingBox();

r = LayoutRect(IntRect(text.firstRunX(), text.firstRunY(), linesBox.width(), linesBox.height()));

- if (adjustForTableCells && !text.firstTextBox())

+ if (adjustForTableCells && !text.hasTextBoxes())

adjustForTableCells = false;

} else if (o.isLayoutInline()) {

// FIXME: Would be better not to just dump 0, 0 as the x and y here.