third_party/WebKit/Source/core/dom/ContainerNode.cpp - Issue 1363913004: [Reland] Invalidate whitespace text on text color changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/dom/ContainerNode.cpp

Issue 1363913004: [Reland] Invalidate whitespace text on text color changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/paint/invalidation/text-decoration-invalidation-expected.html ('k') | third_party/WebKit/Source/core/editing/VisibleUnits.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/dom/ContainerNode.cpp

diff --git a/third_party/WebKit/Source/core/dom/ContainerNode.cpp b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

index d09aab228834ff075cd3b143335afc13e5e40f75..ad91d7d04c3876ff3240c7b2c62c61faa3d692da 100644

--- a/third_party/WebKit/Source/core/dom/ContainerNode.cpp

+++ b/third_party/WebKit/Source/core/dom/ContainerNode.cpp

@@ -938,7 +938,7 @@ bool ContainerNode::getUpperLeftCorner(FloatPoint& point) const

return true;

}

- if (p->node() && p->node() == this && o->isText() && !o->isBR() && !toLayoutText(o)->firstTextBox()) {

+ if (p->node() && p->node() == this && o->isText() && !o->isBR() && !toLayoutText(o)->hasTextBoxes()) {

// Do nothing - skip unrendered whitespace that is a child or next sibling of the anchor.

} else if ((o->isText() && !o->isBR()) || o->isReplaced()) {

point = FloatPoint();