Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Unified Diff: dart.gyp

Issue 13639009: Make the create_sdk build dependent on the dartanalyzer build. This is in (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: dart.gyp
===================================================================
--- dart.gyp (revision 21037)
+++ dart.gyp (working copy)
@@ -31,7 +31,6 @@
'packages',
'runtime',
'samples',
- 'upload_sdk',
],
},
{
@@ -65,6 +64,7 @@
'dependencies': [
'runtime/dart-runtime.gyp:dart',
'utils/compiler/compiler.gyp:dart2js',
+ 'analyzer',
'compiler',
ahe 2013/04/08 08:08:56 Shouldn't you remove the old analyzer?
devoncarew 2013/04/08 09:56:58 Our current plan is to have a few weeks of overlap
'packages'
],
@@ -78,6 +78,7 @@
'<(PRODUCT_DIR)/<(EXECUTABLE_PREFIX)dart<(EXECUTABLE_SUFFIX)',
'<(PRODUCT_DIR)/dart2js.snapshot',
'<(PRODUCT_DIR)/analyzer/bin/dart_analyzer',
+ '<(PRODUCT_DIR)/dartanalyzer/dartanalyzer.jar',
],
'outputs': [
'<(PRODUCT_DIR)/dart-sdk/README',
@@ -92,32 +93,6 @@
],
},
{
- # Upload the SDK. This target is separate from create_sdk as the
- # editor needs to build the SDK without uploading it.
- 'target_name': 'upload_sdk',
- 'type': 'none',
- 'dependencies': [
- 'create_sdk',
- ],
- 'actions': [
- {
- 'action_name': 'upload_sdk_py',
- 'inputs': [
- '<(PRODUCT_DIR)/dart-sdk/README',
- 'tools/upload_sdk.py',
ahe 2013/04/08 08:08:56 Should you remove this script as well?
devoncarew 2013/04/08 09:56:58 I'd like to hold off on that and see what Dan says
- ],
- 'outputs': [
- '<(PRODUCT_DIR)/dart-sdk/upload.stamp',
- ],
- 'action': [
- 'python',
- 'tools/upload_sdk.py',
- '<(PRODUCT_DIR)/dart-sdk'
- ],
- },
- ],
- },
- {
'target_name': 'dart2js',
'type': 'none',
'dependencies': [
@@ -129,7 +104,6 @@
'target_name': 'analyzer',
'type': 'none',
'dependencies': [
- 'create_sdk',
'editor/analyzer.gyp:analyzer',
],
},
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698