Make LabelButton STYLE_NATIVE_TEXTBUTTON focusable; etc.

Make LabelButton STYLE_NATIVE_TEXTBUTTON focusable; etc.

Make LabelButton focusable on set_style(STYLE_NATIVE_TEXTBUTTON).
(this matches NativeTextButton::Init behavior)

Change NativeTextButton to LabelButton in FocusTraversalTest like:
https://codereview.chromium.org/13584010 Patch Set 4.

Update MessageLoopForUI...RunWithDispatcher() test comments.

BUG=155363, 226814
TEST=native style LabelButtons are focusable by default. Tests pass.
R=tfarina@chromium.org,sky@chromium.org
TBR=sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192519

[msw, 2013-04-04 22:47:07]

Hey Thiago and Scott, please take a look; thanks!

[tfarina, 2013-04-04 22:58:46]

https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/labe...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/labe...
ui/views/controls/button/label_button.cc:122: set_border(new
LabelButtonBorder(style));
things are getting messier here, inconsistent use of |style| vs |style_|, can we
use one or the other through out in this function?

https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/labe...
ui/views/controls/button/label_button.cc:124: if (style == STYLE_TEXTBUTTON ||
style == STYLE_NATIVE_TEXTBUTTON)
should we start refactoring here, and have a single if for STYLE_TEXTBUTTON and
another for STYLE_NATIVE_TEXTBUTTON?

[msw, 2013-04-04 23:34:45]

https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/labe...
File ui/views/controls/button/label_button.cc (right):

https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/labe...
ui/views/controls/button/label_button.cc:122: set_border(new
LabelButtonBorder(style));
On 2013/04/04 22:58:46, tfarina wrote:
> things are getting messier here, inconsistent use of |style| vs |style_|, can
we
> use one or the other through out in this function?

Done; I changed the one use of |style_| in this function (besides setting its
value) to |style|.

https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/labe...
ui/views/controls/button/label_button.cc:124: if (style == STYLE_TEXTBUTTON ||
style == STYLE_NATIVE_TEXTBUTTON)
On 2013/04/04 22:58:46, tfarina wrote:
> should we start refactoring here, and have a single if for STYLE_TEXTBUTTON
and
> another for STYLE_NATIVE_TEXTBUTTON?

I think it's okay for now, but might switch it up later.

[tfarina, 2013-04-04 23:52:09]

On 2013/04/04 23:34:45, msw wrote:
>https://codereview.chromium.org/13639003/diff/1/ui/views/controls/button/label_button.cc#newcode124
> ui/views/controls/button/label_button.cc:124: if (style == STYLE_TEXTBUTTON ||
> style == STYLE_NATIVE_TEXTBUTTON)
> On 2013/04/04 22:58:46, tfarina wrote:
> > should we start refactoring here, and have a single if for STYLE_TEXTBUTTON
> and
> > another for STYLE_NATIVE_TEXTBUTTON?
> 
> I think it's okay for now, but might switch it up later.

Agreed. Your changes lgtm. Thanks for investigating!

[commit-bot: I haz the power, 2013-04-05 05:19:40]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/msw@chromium.org/13639003/5001

[commit-bot: I haz the power, 2013-04-05 06:27:54]

Change committed as 192519