Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(21)

Issue 1363893002: Explicitly specify suitable font for combining-marks-position test (Closed)

Created:
4 years ago by drott
Modified:
4 years ago
Reviewers:
eae, behdad
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Explicitly specify suitable font for combining-marks-position test The test case checks for correct rendering of combining marks above the text, instead of for example extending the run length by rendering them as a separate glyph. For the purpose of a robust test case, a font should be chosen that has all the required glyphs. Times New Roman on Linux - which is default selected otherwise - does have a glyph for Heh but does not have a glyph for the Hamza combining mark. Before grapheme cluster font selection, Heh is rendered from Times New Roman, with a Hamza glyph from DejaVu Sans above - which is not optimal. After grapheme cluster based font selection, Heh and Hamza are combined from DejaVu Sans, however, rendered as an isolated glyph separate from the rest of the run, which is not optimal either. More discussion on what is the real fix, e.g. selecting DejaVu Sans for the whole run is in the bug. BUG=535141 R=behdad,eae Committed: https://crrev.com/57f03b0def938c5af026fc7226e5bdae25b78f7d Cr-Commit-Position: refs/heads/master@{#350513}

Patch Set 1 #

Patch Set 2 : rebased to chromium repo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -2 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/text/international/combining-marks-position.html View 1 2 chunks +11 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
drott
4 years ago (2015-09-23 12:10:34 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363893002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363893002/1
4 years ago (2015-09-23 12:10:45 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/116800)
4 years ago (2015-09-23 12:16:20 UTC) #5
eae
LGTM
4 years ago (2015-09-23 13:51:37 UTC) #6
drott
rebased to chromium repo
4 years ago (2015-09-23 15:44:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363893002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363893002/20001
4 years ago (2015-09-24 08:48:38 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years ago (2015-09-24 09:25:22 UTC) #11
commit-bot: I haz the power
4 years ago (2015-09-24 09:26:38 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/57f03b0def938c5af026fc7226e5bdae25b78f7d
Cr-Commit-Position: refs/heads/master@{#350513}

Powered by Google App Engine
This is Rietveld 408576698