Index: src/ia32/builtins-ia32.cc |
diff --git a/src/ia32/builtins-ia32.cc b/src/ia32/builtins-ia32.cc |
index 15f3ace14ec28edffe5ab5a09f0ddb26bff301dc..7a055bd8766d5331cb16bd930b55fa5b81e4f316 100644 |
--- a/src/ia32/builtins-ia32.cc |
+++ b/src/ia32/builtins-ia32.cc |
@@ -1109,6 +1109,7 @@ void Builtins::Generate_FunctionCall(MacroAssembler* masm) { |
static void Generate_PushAppliedArguments(MacroAssembler* masm, |
+ const int vectorOffset, |
const int argumentsOffset, |
const int indexOffset, |
const int limitOffset) { |
@@ -1124,13 +1125,9 @@ static void Generate_PushAppliedArguments(MacroAssembler* masm, |
__ mov(receiver, Operand(ebp, argumentsOffset)); // load arguments |
// Use inline caching to speed up access to arguments. |
- Code::Kind kinds[] = {Code::KEYED_LOAD_IC}; |
- FeedbackVectorSpec spec(0, 1, kinds); |
- Handle<TypeFeedbackVector> feedback_vector = |
- masm->isolate()->factory()->NewTypeFeedbackVector(&spec); |
- int index = feedback_vector->GetIndex(FeedbackVectorICSlot(0)); |
- __ mov(slot, Immediate(Smi::FromInt(index))); |
- __ mov(vector, Immediate(feedback_vector)); |
+ int slot_index = TypeFeedbackVector::PushAppliedArgumentsIndex(); |
+ __ mov(slot, Immediate(Smi::FromInt(slot_index))); |
+ __ mov(vector, Operand(ebp, vectorOffset)); |
Handle<Code> ic = |
KeyedLoadICStub(masm->isolate(), LoadICState(kNoExtraICState)).GetCode(); |
__ call(ic, RelocInfo::CODE_TARGET); |
@@ -1178,6 +1175,13 @@ static void Generate_ApplyHelper(MacroAssembler* masm, bool targetIsArgument) { |
static const int kArgumentsOffset = kFPOnStackSize + kPCOnStackSize; |
static const int kReceiverOffset = kArgumentsOffset + kPointerSize; |
static const int kFunctionOffset = kReceiverOffset + kPointerSize; |
+ static const int kVectorOffset = |
+ InternalFrameConstants::kCodeOffset - 1 * kPointerSize; |
+ |
+ // Push the vector. |
+ __ mov(edi, FieldOperand(edi, JSFunction::kSharedFunctionInfoOffset)); |
+ __ mov(edi, FieldOperand(edi, SharedFunctionInfo::kFeedbackVectorOffset)); |
+ __ push(edi); |
__ push(Operand(ebp, kFunctionOffset)); // push this |
__ push(Operand(ebp, kArgumentsOffset)); // push arguments |
@@ -1190,8 +1194,7 @@ static void Generate_ApplyHelper(MacroAssembler* masm, bool targetIsArgument) { |
Generate_CheckStackOverflow(masm, kFunctionOffset, kEaxIsSmiTagged); |
// Push current index and limit. |
- const int kLimitOffset = |
- StandardFrameConstants::kExpressionsOffset - 1 * kPointerSize; |
+ const int kLimitOffset = kVectorOffset - 1 * kPointerSize; |
const int kIndexOffset = kLimitOffset - 1 * kPointerSize; |
__ push(eax); // limit |
__ push(Immediate(0)); // index |
@@ -1252,8 +1255,8 @@ static void Generate_ApplyHelper(MacroAssembler* masm, bool targetIsArgument) { |
__ push(ebx); |
// Loop over the arguments array, pushing each value to the stack |
- Generate_PushAppliedArguments( |
- masm, kArgumentsOffset, kIndexOffset, kLimitOffset); |
+ Generate_PushAppliedArguments(masm, kVectorOffset, kArgumentsOffset, |
+ kIndexOffset, kLimitOffset); |
// Call the function. |
Label call_proxy; |
@@ -1302,6 +1305,13 @@ static void Generate_ConstructHelper(MacroAssembler* masm) { |
static const int kNewTargetOffset = kFPOnStackSize + kPCOnStackSize; |
static const int kArgumentsOffset = kNewTargetOffset + kPointerSize; |
static const int kFunctionOffset = kArgumentsOffset + kPointerSize; |
+ static const int kVectorOffset = |
+ InternalFrameConstants::kCodeOffset - 1 * kPointerSize; |
+ |
+ // Push the vector. |
+ __ mov(edi, FieldOperand(edi, JSFunction::kSharedFunctionInfoOffset)); |
+ __ mov(edi, FieldOperand(edi, SharedFunctionInfo::kFeedbackVectorOffset)); |
+ __ push(edi); |
// If newTarget is not supplied, set it to constructor |
Label validate_arguments; |
@@ -1321,8 +1331,7 @@ static void Generate_ConstructHelper(MacroAssembler* masm) { |
Generate_CheckStackOverflow(masm, kFunctionOffset, kEaxIsSmiTagged); |
// Push current index and limit. |
- const int kLimitOffset = |
- StandardFrameConstants::kExpressionsOffset - 1 * kPointerSize; |
+ const int kLimitOffset = kVectorOffset - 1 * kPointerSize; |
const int kIndexOffset = kLimitOffset - 1 * kPointerSize; |
__ Push(eax); // limit |
__ push(Immediate(0)); // index |
@@ -1330,8 +1339,8 @@ static void Generate_ConstructHelper(MacroAssembler* masm) { |
__ push(Operand(ebp, kFunctionOffset)); |
// Loop over the arguments array, pushing each value to the stack |
- Generate_PushAppliedArguments( |
- masm, kArgumentsOffset, kIndexOffset, kLimitOffset); |
+ Generate_PushAppliedArguments(masm, kVectorOffset, kArgumentsOffset, |
+ kIndexOffset, kLimitOffset); |
// Use undefined feedback vector |
__ LoadRoot(ebx, Heap::kUndefinedValueRootIndex); |