Drop unnecessary ancestor traversal in Range::selectNode()

Drop unnecessary ancestor traversal in Range::selectNode().

It traversed the ancestors to throw a INVALID_NODE_TYPE_ERR if one of them was a DocumentType Node. However, it is impossible for a DocumentType Node to have children.

Picked from webkit https://trac.webkit.org/changeset/190145

No new tests, covered by existing tests.

BUG=None

Committed: https://crrev.com/33c1357fd8454b712f316958555df0de7f24476b
Cr-Commit-Position: refs/heads/master@{#351046}

[pals, 2015-09-23 06:02:38]

sanjoy.pal@samsung.com changed reviewers:
+ chirshtr@chromium.org

[pals, 2015-09-23 06:04:55]

sanjoy.pal@samsung.com changed reviewers:
+ ager@chromium.org
- chirshtr@chromium.org

[pals, 2015-09-23 07:01:20]

PTAL. Thanks

[sof, 2015-09-23 10:01:39]

sigbjornf@opera.com changed reviewers:
+ sigbjornf@opera.com

[sof, 2015-09-23 10:01:39]

https://codereview.chromium.org/1363833002/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/1363833002/diff/1/Source/core/dom/Range.cpp#n...
Source/core/dom/Range.cpp:1083: // INVALID_NODE_TYPE_ERR: Raised if refNode is a
Document, DocumentFragment or Attr node.
InvalidNodeTypeError, not INVALID_NODE_TYPE_ERR, but the comment doesn't add any
value, so just remove it.

[pals, 2015-09-23 11:34:35]

Removed the comment. Please review.

https://codereview.chromium.org/1363833002/diff/1/Source/core/dom/Range.cpp
File Source/core/dom/Range.cpp (right):

https://codereview.chromium.org/1363833002/diff/1/Source/core/dom/Range.cpp#n...
Source/core/dom/Range.cpp:1083: // INVALID_NODE_TYPE_ERR: Raised if refNode is a
Document, DocumentFragment or Attr node.
On 2015/09/23 10:01:39, sof wrote:
> InvalidNodeTypeError, not INVALID_NODE_TYPE_ERR, but the comment doesn't add
any
> value, so just remove it.

Done.

[sof, 2015-09-23 11:39:58]

lgtm

[pals, 2015-09-23 12:01:00]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2015-09-23 12:01:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363833002/20001

[commit-bot: I haz the power, 2015-09-23 12:08:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 12:08:45]

Try jobs failed on following builders:
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pals, 2015-09-23 13:22:29]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2015-09-23 13:22:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363833002/20001

[commit-bot: I haz the power, 2015-09-23 13:27:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-23 13:27:32]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pals, 2015-09-28 04:17:58]

The CQ bit was checked by sanjoy.pal@samsung.com

[commit-bot: I haz the power, 2015-09-28 04:18:09]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363833002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363833002/20001

[commit-bot: I haz the power, 2015-09-28 04:18:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-09-28 04:18:51]

Try jobs failed on following builders:
  cast_shell_android on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_andr...)
  linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pals, 2015-09-28 06:26:15]

The CQ bit was checked by sanjoy.pal@samsung.com

[pals, 2015-09-28 06:26:16]

The patchset sent to the CQ was uploaded after l-g-t-m from sigbjornf@opera.com
Link to the patchset: https://codereview.chromium.org/1363833002/#ps40001
(title: "rebased wrt chromium repo")

[commit-bot: I haz the power, 2015-09-28 06:27:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1363833002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1363833002/40001

[commit-bot: I haz the power, 2015-09-28 09:43:40]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-09-28 09:44:24]

Patchset 3 (id:??) landed as
https://crrev.com/33c1357fd8454b712f316958555df0de7f24476b
Cr-Commit-Position: refs/heads/master@{#351046}