Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 136383004: [GCM] Add gcm_unit_tests to aura_builder target (Closed)

Created:
6 years, 11 months ago by Nicolas Zea
Modified:
6 years, 11 months ago
Reviewers:
jianli
CC:
chromium-reviews
Visibility:
Public.

Description

[GCM] Add gcm_unit_tests to aura_builder target BUG=284553 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=246455

Patch Set 1 #

Patch Set 2 : Fix aura_builder #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M build/all.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nicolas Zea
PTAL, this fixes two trybots (linux_aura and linux_chromeos) that were failing to find the target.
6 years, 11 months ago (2014-01-22 21:49:51 UTC) #1
jianli
lgtm
6 years, 11 months ago (2014-01-22 21:58:16 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/136383004/90001
6 years, 11 months ago (2014-01-22 22:34:39 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-23 00:15:26 UTC) #4
Message was sent while issue was closed. 
Change committed as 246455

Powered by Google App Engine
This is Rietveld 408576698