Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 1363803003: Remove ChromeRenderFrameObserver::HasRefreshMetaTag. (Closed)

Created:
5 years, 2 months ago by dglazkov
Modified:
5 years, 2 months ago
Reviewers:
jam
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove ChromeRenderFrameObserver::HasRefreshMetaTag. Instead of poking at the DOM, there is a gentler and more accurate way to determine whether the document has a pending location change or a redirect. Let's use it! BUG=521166 R=jam Committed: https://crrev.com/7829929371d16e6caeaa604d009bba534479eb20 Cr-Commit-Position: refs/heads/master@{#351021}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -34 lines) Patch
M chrome/renderer/chrome_render_frame_observer.h View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/renderer/chrome_render_frame_observer.cc View 3 chunks +5 lines, -31 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363803003/1
5 years, 2 months ago (2015-09-25 23:29:04 UTC) #2
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-09-26 00:09:20 UTC) #4
dglazkov
PTAL.
5 years, 2 months ago (2015-09-26 00:11:36 UTC) #5
jam
lgtm
5 years, 2 months ago (2015-09-28 02:49:48 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363803003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363803003/1
5 years, 2 months ago (2015-09-28 03:07:25 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-09-28 04:10:33 UTC) #9
commit-bot: I haz the power
5 years, 2 months ago (2015-09-28 04:11:27 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7829929371d16e6caeaa604d009bba534479eb20
Cr-Commit-Position: refs/heads/master@{#351021}

Powered by Google App Engine
This is Rietveld 408576698