Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(593)

Issue 1363803002: Revert of [Sync] Move data type logic from PSSA to PSS. (Closed)

Created:
5 years, 3 months ago by jbudorick
Modified:
5 years, 3 months ago
Reviewers:
maxbogue, Nicolas Zea
CC:
chromium-reviews, tim+watch_chromium.org, pvalenzuela+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [Sync] Move data type logic from PSSA to PSS. (patchset #6 id:100001 of https://codereview.chromium.org/1304933010/ ) Reason for revert: broke sync instrumentation tests: http://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/22408 Original issue's description: > [Sync] Move data type logic from PSSA to PSS. > > Now PSS::OnUserChoseDatatypes filters to only user selectable types, > and GetPreferredDataTypes() will always include the control types. > > BUG=497518 > > Committed: https://crrev.com/0f5131e4f6ae03647aae0cac8154bf888b844e95 > Cr-Commit-Position: refs/heads/master@{#350230} TBR=zea@chromium.org,maxbogue@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=497518 Committed: https://crrev.com/121c0328c09332f88713ddf0691e71ee00798002 Cr-Commit-Position: refs/heads/master@{#350295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M chrome/browser/sync/profile_sync_service.cc View 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_android.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M chrome/browser/sync/test/integration/enable_disable_test.cc View 1 chunk +3 lines, -6 lines 0 comments Download
M chrome/browser/sync/test/integration/profile_sync_service_harness.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/sync/test/integration/sync_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/sync_driver/sync_service.h View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
jbudorick
Created Revert of [Sync] Move data type logic from PSSA to PSS.
5 years, 3 months ago (2015-09-23 03:57:57 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1363803002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1363803002/1
5 years, 3 months ago (2015-09-23 03:58:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-23 03:59:57 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-23 04:00:37 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/121c0328c09332f88713ddf0691e71ee00798002
Cr-Commit-Position: refs/heads/master@{#350295}

Powered by Google App Engine
This is Rietveld 408576698