runtime/bin/directory_win.cc - Issue 13638028: Report same error-code on windows for all not-found cases.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/directory_win.cc

Issue 13638028: Report same error-code on windows for all not-found cases. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 7 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/bin/directory_win.cc

diff --git a/runtime/bin/directory_win.cc b/runtime/bin/directory_win.cc

index 7ee9b593cd22a2fadd8af116b85a769821503a0c..c8058540b0ab993189406a1011725ed015872e79 100644

--- a/runtime/bin/directory_win.cc

+++ b/runtime/bin/directory_win.cc

@@ -430,7 +430,7 @@ bool Directory::Delete(const char* dir_name, bool recursive) {

if (File::GetType(dir_name, true) == File::kIsDirectory) {

result = (RemoveDirectoryW(system_dir_name) != 0);

} else {

- SetLastError(ERROR_DIRECTORY);

+ SetLastError(ERROR_FILE_NOT_FOUND);

}

} else {

PathBuffer path;

« no previous file with comments | « no previous file | no next file » | no next file with comments »