Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 13638010: Support storing the VisibilityClient on windows other than the RootWindow. What this means is you c… (Closed)

Created:
7 years, 8 months ago by Ben Goodger (Google)
Modified:
7 years, 8 months ago
Reviewers:
sky
CC:
chromium-reviews, sadrul, ben+watch_chromium.org
Visibility:
Public.

Description

Support storing the VisibilityClient on windows other than the RootWindow. What this means is you can set an object implementing VisibilityClient on any window in the hierarchy and this impl will handle layer visibility changes for that subtree. R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=192651

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -16 lines) Patch
M ui/aura/client/visibility_client.h View 2 chunks +6 lines, -5 lines 0 comments Download
M ui/aura/client/visibility_client.cc View 1 chunk +12 lines, -6 lines 0 comments Download
M ui/aura/window.cc View 1 chunk +5 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Ben Goodger (Google)
7 years, 8 months ago (2013-04-05 19:17:15 UTC) #1
sky
This looks good, but do you need to update any existing VisibilityClients to ignore children ...
7 years, 8 months ago (2013-04-05 19:24:57 UTC) #2
Ben Goodger (Google)
I don't believe it represents a change for the existing clients, because it was only ...
7 years, 8 months ago (2013-04-05 19:28:06 UTC) #3
sky
Ah, ok. LGTM
7 years, 8 months ago (2013-04-05 19:29:49 UTC) #4
Ben Goodger (Google)
7 years, 8 months ago (2013-04-05 23:33:54 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r192651 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698