Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1595)

Issue 13638002: Move StackHandlerConstants to platform-independent frames.h (Closed)

Created:
7 years, 8 months ago by wingo
Modified:
7 years, 8 months ago
Base URL:
git://github.com/v8/v8.git@master
Visibility:
Public.

Description

Move StackHandlerConstants to platform-independent frames.h * src/frames.h: Move StackHandlerConstants here, as it is the same for all architectures. BUG= Committed: http://code.google.com/p/v8/source/detail?r=14161

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -48 lines) Patch
M src/arm/frames-arm.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/frames.h View 1 chunk +12 lines, -0 lines 0 comments Download
M src/ia32/frames-ia32.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/mips/frames-mips.h View 1 chunk +0 lines, -12 lines 0 comments Download
M src/x64/frames-x64.h View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
wingo
7 years, 8 months ago (2013-04-04 13:12:33 UTC) #1
Michael Starzinger
LGTM. I'll land this.
7 years, 8 months ago (2013-04-08 11:12:56 UTC) #2
Michael Starzinger
7 years, 8 months ago (2013-04-08 11:17:46 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r14161 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698