pkg/json/lib/json.dart - Issue 136373002: Fix JSON encoder accepting NaN and Infinity.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/json/lib/json.dart

Issue 136373002: Fix JSON encoder accepting NaN and Infinity. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/json/lib/json.dart

diff --git a/pkg/json/lib/json.dart b/pkg/json/lib/json.dart

index f7063382c6ddb05aa8a4ec6cfa7da1c985a8d960..4c6732275c515dae62587880cc3877274003a195 100644

--- a/pkg/json/lib/json.dart

+++ b/pkg/json/lib/json.dart

@@ -769,7 +769,7 @@ class _JsonStringifier {

bool stringifyJsonValue(final object) {

if (object is num) {

- // TODO: use writeOn.

+ if (!object.isFinite) return false;

sink.write(numberToString(object));

return true;

} else if (identical(object, true)) {

« no previous file with comments | « no previous file | pkg/json/test/json_test.dart » ('j') | no next file with comments »