Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(703)

Issue 136373002: Fix JSON encoder accepting NaN and Infinity. (Closed)

Created:
6 years, 11 months ago by Lasse Reichstein Nielsen
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix JSON encoder accepting NaN and Infinity. BUG= http://dartbug.com/16038 R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=31731

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -637 lines) Patch
M pkg/json/lib/json.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/json/test/json_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download
M sdk/lib/convert/json.dart View 2 chunks +1 line, -2 lines 0 comments Download
D tests/corelib/json_test.dart View 1 chunk +0 lines, -269 lines 0 comments Download
A + tests/lib/convert/json_lib_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
A + tests/lib/convert/json_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
A + tests/lib/convert/json_util_test.dart View 0 chunks +-1 lines, --1 lines 0 comments Download
D tests/lib/json/json_test.dart View 1 chunk +0 lines, -189 lines 0 comments Download
D tests/utils/json_test.dart View 1 chunk +0 lines, -178 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein Nielsen
6 years, 11 months ago (2014-01-13 09:17:54 UTC) #1
Lasse Reichstein Nielsen
6 years, 11 months ago (2014-01-13 09:18:14 UTC) #2
Søren Gjesse
lgtm
6 years, 11 months ago (2014-01-13 09:20:51 UTC) #3
Lasse Reichstein Nielsen
6 years, 11 months ago (2014-01-13 10:00:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r31731 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698