components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java - Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: update Ben's tests Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/cronet/android/java/src/org/chromium/net/UrlRequestListener.java ('k') | components/cronet/android/java/src/org/chromium/net/urlconnection/CronetHttpURLConnection.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java

diff --git a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java

index a7db52784d8ea4c0c564c3b691dc19035aac97b5..e5a7090c3faca500d76507538e6d0100292bf8d2 100644

--- a/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java

+++ b/components/cronet/android/java/src/org/chromium/net/urlconnection/CronetBufferedOutputStream.java

@@ -146,7 +146,8 @@ final class CronetBufferedOutputStream extends CronetOutputStream {

// TODO(xunjieli): Think of a less fragile way, since getLength() can be

// potentially called in other places in the future.

if (mInitialContentLength == -1) {

- return mBuffer.position();

+ // Account for the fact that setConnected() flip()s mBuffer.

+ return mConnected ? mBuffer.limit() : mBuffer.position();

}

return mInitialContentLength;

}