Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: address Misha's comments Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java
index 110bcf7f7128c1f976ad3ee070d141e911b5d787..c35ccfc4b0d384af6d8e93bf380cec88326f726f 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/urlconnection/CronetURLStreamHandlerFactoryTest.java
@@ -10,15 +10,18 @@ import org.chromium.base.test.util.Feature;
import org.chromium.net.CronetTestActivity;
import org.chromium.net.CronetTestBase;
+/**
+ * Test for CronetURLStreamHandlerFactory.
+ */
public class CronetURLStreamHandlerFactoryTest extends CronetTestBase {
@SmallTest
@Feature({"Cronet"})
public void testRequireConfig() throws Exception {
CronetTestActivity activity = launchCronetTestApp();
mef 2015/10/05 19:52:43 FindBugs reported the following issues: DLS_DEAD_L
pauljensen 2015/10/06 13:07:08 Done.
try {
- new CronetURLStreamHandlerFactory(activity, null);
+ new CronetURLStreamHandlerFactory(null);
} catch (NullPointerException e) {
- assertEquals("UrlRequestContextConfig is null.", e.getMessage());
+ assertEquals("CronetEngine is null.", e.getMessage());
}
}
}

Powered by Google App Engine
This is Rietveld 408576698