Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make old API work without renaming Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java
diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java
index 8291ce0c4e379e121910640c961bf87ae7ffa92a..a4d9eefb34b4ce9eabc3d495ab767c1531234c68 100644
--- a/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java
+++ b/components/cronet/android/test/javatests/src/org/chromium/net/GetStatusTest.java
@@ -45,7 +45,7 @@ public class GetStatusTest extends CronetTestBase {
@Override
protected void tearDown() throws Exception {
NativeTestServer.shutdownNativeTestServer();
- mActivity.mUrlRequestContext.shutdown();
+ mActivity.mCronetEngine.shutdown();
super.tearDown();
}
@@ -55,16 +55,9 @@ public class GetStatusTest extends CronetTestBase {
String url = NativeTestServer.getEchoMethodURL();
TestUrlRequestListener listener = new TestUrlRequestListener();
listener.setAutoAdvance(false);
- UrlRequest urlRequest =
- mActivity.mUrlRequestContext.createRequest(url, listener, listener.getExecutor());
- // Calling before request is started should give Status.INVALID,
- // since the native adapter is not created.
- TestStatusListener statusListener0 = new TestStatusListener();
mef 2015/10/02 16:46:58 Can't do that, nice!
pauljensen 2015/10/02 18:23:15 Oops, actually you can now that we added back star
- urlRequest.getStatus(statusListener0);
- statusListener0.waitUntilOnStatusCalled();
- assertTrue(statusListener0.mOnStatusCalled);
- assertEquals(Status.INVALID, statusListener0.mStatus);
-
+ UrlRequest.Builder builder = new UrlRequest.Builder(
+ url, listener, listener.getExecutor(), mActivity.mCronetEngine);
+ UrlRequest urlRequest = builder.build();
urlRequest.start();
// Should receive a valid status.

Powered by Google App Engine
This is Rietveld 408576698