Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java

Issue 1363723002: [Cronet] Create Builders, rename UrlRequestContext to CronetEngine (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: make old API work without renaming Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java
diff --git a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java
index 3da1c38ca1fd9486e1c971b3f7761712f224fb69..67f3b9d5a1ddc9137b2e6c0aefc694d482174f50 100644
--- a/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java
+++ b/components/cronet/android/java/src/org/chromium/net/HttpUrlRequestFactoryConfig.java
@@ -4,27 +4,28 @@
package org.chromium.net;
+import android.content.Context;
+
import org.json.JSONException;
/**
* A config for HttpUrlRequestFactory, which allows runtime configuration of
* HttpUrlRequestFactory.
- * @deprecated Use {@link UrlRequestContextConfig} instead.
+ * @deprecated Use {@link CronetEngine.Builder} instead.
*/
@Deprecated
-public class HttpUrlRequestFactoryConfig extends UrlRequestContextConfig {
-
+public class HttpUrlRequestFactoryConfig extends CronetEngine.Builder {
/**
* Default config enables SPDY, QUIC, in memory http cache.
*/
- public HttpUrlRequestFactoryConfig() {
- super();
+ public HttpUrlRequestFactoryConfig(Context context) {
mef 2015/10/02 16:46:58 this needs default constructor. Can we do super(n
pauljensen 2015/10/02 18:23:15 Done.
+ super(context);
}
/**
* Create config from json serialized using @toString.
*/
- public HttpUrlRequestFactoryConfig(String json) throws JSONException {
- super(json);
+ public HttpUrlRequestFactoryConfig(Context context, String json) throws JSONException {
+ super(context, json);
}
}

Powered by Google App Engine
This is Rietveld 408576698